kubernetes
/
autoscaler
mirror of https://github.com/kubernetes/autoscaler.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

review fixes. 

added explicit ignoring for write func
This commit is contained in:
Jayant Jain 2020-10-01 14:35:43 +00:00
parent 7fa7a14af6
commit d987394c55
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cluster-autoscaler/cloudprovider/gce/mig_target_sizes_provider.go
View File

@ -56,9 +56,9 @@ func (c *cachingMigTargetSizesProvider) GetMigTargetSize(migRef GceRef) (int64,
newTargetSizes, err := c.fillInMigTargetSizeCache() newTargetSizes, err := c.fillInMigTargetSizeCache()
// if we still do not have value here return an error
size, found := newTargetSizes[migRef] size, found := newTargetSizes[migRef]
if err != nil || !found { if err != nil || !found {
// fallback to querying for single mig
targetSize, err = c.gceClient.FetchMigTargetSize(migRef) targetSize, err = c.gceClient.FetchMigTargetSize(migRef)
if err != nil { if err != nil {
return 0, err return 0, err

5
cluster-autoscaler/utils/test/test_utils.go
View File

@ -225,7 +225,7 @@ func NewHttpServerMock() *HttpServerMock {
mux.HandleFunc("/", mux.HandleFunc("/",
func(w http.ResponseWriter, req *http.Request) { func(w http.ResponseWriter, req *http.Request) {
result := httpServerMock.handle(req.URL.Path) result := httpServerMock.handle(req.URL.Path)
w.Write([]byte(result)) _, _ = w.Write([]byte(result))
}) })
server := httptest.NewServer(mux) server := httptest.NewServer(mux)
@ -246,8 +246,7 @@ func NewHttpServerMockWithStatusCode() *HttpServerMock {
func(w http.ResponseWriter, req *http.Request) { func(w http.ResponseWriter, req *http.Request) {
code, result := httpServerMock.handleWithStatusCode(req.URL.Path) code, result := httpServerMock.handleWithStatusCode(req.URL.Path)
w.WriteHeader(code) w.WriteHeader(code)
w.Write([]byte(result)) _, _ = w.Write([]byte(result))
//w.Write([]byte("status: " + string(code) + "\n" + result))
}) })
server := httptest.NewServer(mux) server := httptest.NewServer(mux)