autoscaler

Commit Graph

Author	SHA1	Message	Date
Joel Speed	f369843353	Check ASG name list not empty	2017-08-30 13:50:17 +01:00
Seth Pollack	314ed88b14	Enable min size 0 in aws	2017-07-10 09:04:18 -04:00
Yusuke Kuoka	dfb481b19f	cluster-autoscaler: Fix excessive calls to DescribeAutoScalingGroup By caching AWS refs for nodes/EC2 instances already known to be not in any of ASGs managed by cluster-autoscaler(CA). Please beware of the edge case - this method is safe as long as users don't attach nodes by calling AttachInstances API after CA cached them. I believe, even if it was necessary, a warning in the documentation about the edge case is enough for now. If we really need to support the case, I will submit an another PR to invalidate the cache periodically so that CA can detect the formerly cached nodes are attached to ASG(s). Also refactor AwsManager for less complexity by extracting types, accordingly to the discussion made [here](https://github.com/kubernetes/autoscaler/pull/46#discussion_r117912687)	2017-06-22 16:55:15 +09:00

Author

SHA1

Message

Date

Joel Speed

f369843353

Check ASG name list not empty

2017-08-30 13:50:17 +01:00

Seth Pollack

314ed88b14

Enable min size 0 in aws

2017-07-10 09:04:18 -04:00

Yusuke Kuoka

dfb481b19f

cluster-autoscaler: Fix excessive calls to DescribeAutoScalingGroup

By caching AWS refs for nodes/EC2 instances already known to be not in any of ASGs managed by cluster-autoscaler(CA).

Please beware of the edge case - this method is safe as long as users don't attach nodes by calling AttachInstances API after CA cached them. I believe, even if it was necessary, a warning in the documentation about the edge case is enough for now. If we really need to support the case, I will submit an another PR to invalidate the cache periodically so that CA can detect the formerly cached nodes are attached to ASG(s).

Also refactor AwsManager for less complexity by extracting types, accordingly to the discussion made [here](https://github.com/kubernetes/autoscaler/pull/46#discussion_r117912687)

2017-06-22 16:55:15 +09:00

3 Commits