autoscaler/cluster-autoscaler/cloudprovider/aws/aws_wrapper_test.go

439 lines
12 KiB
Go

/*
Copyright 2016 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package aws
import (
"fmt"
"os"
"strconv"
"testing"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/autoscaling"
"github.com/aws/aws-sdk-go/service/ec2"
"github.com/aws/aws-sdk-go/service/eks"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
apiv1 "k8s.io/api/core/v1"
)
type autoScalingMock struct {
mock.Mock
}
func (a *autoScalingMock) DescribeAutoScalingGroupsPages(i *autoscaling.DescribeAutoScalingGroupsInput, fn func(*autoscaling.DescribeAutoScalingGroupsOutput, bool) bool) error {
args := a.Called(i, fn)
return args.Error(0)
}
func (a *autoScalingMock) DescribeLaunchConfigurations(i *autoscaling.DescribeLaunchConfigurationsInput) (*autoscaling.DescribeLaunchConfigurationsOutput, error) {
args := a.Called(i)
return args.Get(0).(*autoscaling.DescribeLaunchConfigurationsOutput), nil
}
func (a *autoScalingMock) DescribeTagsPages(i *autoscaling.DescribeTagsInput, fn func(*autoscaling.DescribeTagsOutput, bool) bool) error {
args := a.Called(i, fn)
return args.Error(0)
}
func (a *autoScalingMock) SetDesiredCapacity(input *autoscaling.SetDesiredCapacityInput) (*autoscaling.SetDesiredCapacityOutput, error) {
args := a.Called(input)
return args.Get(0).(*autoscaling.SetDesiredCapacityOutput), nil
}
func (a *autoScalingMock) TerminateInstanceInAutoScalingGroup(input *autoscaling.TerminateInstanceInAutoScalingGroupInput) (*autoscaling.TerminateInstanceInAutoScalingGroupOutput, error) {
args := a.Called(input)
return args.Get(0).(*autoscaling.TerminateInstanceInAutoScalingGroupOutput), nil
}
type ec2Mock struct {
mock.Mock
}
func (e *ec2Mock) DescribeLaunchTemplateVersions(i *ec2.DescribeLaunchTemplateVersionsInput) (*ec2.DescribeLaunchTemplateVersionsOutput, error) {
args := e.Called(i)
return args.Get(0).(*ec2.DescribeLaunchTemplateVersionsOutput), nil
}
type eksMock struct {
mock.Mock
}
func (k *eksMock) DescribeNodegroup(i *eks.DescribeNodegroupInput) (*eks.DescribeNodegroupOutput, error) {
args := k.Called(i)
return args.Get(0).(*eks.DescribeNodegroupOutput), nil
}
var testAwsService = awsWrapper{&autoScalingMock{}, &ec2Mock{}, &eksMock{}}
func TestGetManagedNodegroup(t *testing.T) {
k := &eksMock{}
awsWrapper := &awsWrapper{
autoScalingI: nil,
ec2I: nil,
eksI: k,
}
labelKey1 := "labelKey 1"
labelKey2 := "labelKey 2"
labelValue1 := "testValue 1"
labelValue2 := "testValue 2"
nodegroupName := "testNodegroup"
clusterName := "testCluster"
taintEffect1 := "effect 1"
taintKey1 := "key 1"
taintValue1 := "value 1"
taint1 := eks.Taint{
Effect: &taintEffect1,
Key: &taintKey1,
Value: &taintValue1,
}
taintEffect2 := "effect 2"
taintKey2 := "key 2"
taintValue2 := "value 2"
taint2 := eks.Taint{
Effect: &taintEffect2,
Key: &taintKey2,
Value: &taintValue2,
}
amiType := "testAmiType"
diskSize := int64(100)
capacityType := "testCapacityType"
k8sVersion := "1.19"
// Create test nodegroup
testNodegroup := eks.Nodegroup{
AmiType: &amiType,
ClusterName: &clusterName,
DiskSize: &diskSize,
Labels: map[string]*string{labelKey1: &labelValue1, labelKey2: &labelValue2},
NodegroupName: &nodegroupName,
CapacityType: &capacityType,
Version: &k8sVersion,
Taints: []*eks.Taint{&taint1, &taint2},
}
k.On("DescribeNodegroup", &eks.DescribeNodegroupInput{
ClusterName: &clusterName,
NodegroupName: &nodegroupName,
}).Return(&eks.DescribeNodegroupOutput{Nodegroup: &testNodegroup})
taintList, labelMap, err := awsWrapper.getManagedNodegroupInfo(nodegroupName, clusterName)
assert.Nil(t, err)
assert.Equal(t, len(taintList), 2)
assert.Equal(t, taintList[0].Effect, apiv1.TaintEffect(taintEffect1))
assert.Equal(t, taintList[0].Key, taintKey1)
assert.Equal(t, taintList[0].Value, taintValue1)
assert.Equal(t, taintList[1].Effect, apiv1.TaintEffect(taintEffect2))
assert.Equal(t, taintList[1].Key, taintKey2)
assert.Equal(t, taintList[1].Value, taintValue2)
assert.Equal(t, len(labelMap), 6)
assert.Equal(t, labelMap[labelKey1], labelValue1)
assert.Equal(t, labelMap[labelKey2], labelValue2)
assert.Equal(t, labelMap["diskSize"], strconv.FormatInt(diskSize, 10))
assert.Equal(t, labelMap["amiType"], amiType)
assert.Equal(t, labelMap["capacityType"], capacityType)
assert.Equal(t, labelMap["k8sVersion"], k8sVersion)
}
func TestGetManagedNodegroupWithNilValues(t *testing.T) {
k := &eksMock{}
awsWrapper := &awsWrapper{
autoScalingI: nil,
ec2I: nil,
eksI: k,
}
nodegroupName := "testNodegroup"
clusterName := "testCluster"
amiType := "testAmiType"
capacityType := "testCapacityType"
k8sVersion := "1.19"
// Create test nodegroup
testNodegroup := eks.Nodegroup{
AmiType: &amiType,
ClusterName: &clusterName,
DiskSize: nil,
Labels: nil,
NodegroupName: &nodegroupName,
CapacityType: &capacityType,
Version: &k8sVersion,
Taints: nil,
}
k.On("DescribeNodegroup", &eks.DescribeNodegroupInput{
ClusterName: &clusterName,
NodegroupName: &nodegroupName,
}).Return(&eks.DescribeNodegroupOutput{Nodegroup: &testNodegroup})
taintList, labelMap, err := awsWrapper.getManagedNodegroupInfo(nodegroupName, clusterName)
assert.Nil(t, err)
assert.Equal(t, len(taintList), 0)
assert.Equal(t, len(labelMap), 3)
assert.Equal(t, labelMap["amiType"], amiType)
assert.Equal(t, labelMap["capacityType"], capacityType)
assert.Equal(t, labelMap["k8sVersion"], k8sVersion)
}
func TestGetManagedNodegroupWithEmptyValues(t *testing.T) {
k := &eksMock{}
awsWrapper := &awsWrapper{
autoScalingI: nil,
ec2I: nil,
eksI: k,
}
nodegroupName := "testNodegroup"
clusterName := "testCluster"
amiType := "testAmiType"
capacityType := "testCapacityType"
k8sVersion := "1.19"
// Create test nodegroup
testNodegroup := eks.Nodegroup{
AmiType: &amiType,
ClusterName: &clusterName,
DiskSize: nil,
Labels: make(map[string]*string),
NodegroupName: &nodegroupName,
CapacityType: &capacityType,
Version: &k8sVersion,
Taints: make([]*eks.Taint, 0),
}
k.On("DescribeNodegroup", &eks.DescribeNodegroupInput{
ClusterName: &clusterName,
NodegroupName: &nodegroupName,
}).Return(&eks.DescribeNodegroupOutput{Nodegroup: &testNodegroup})
taintList, labelMap, err := awsWrapper.getManagedNodegroupInfo(nodegroupName, clusterName)
assert.Nil(t, err)
assert.Equal(t, len(taintList), 0)
assert.Equal(t, len(labelMap), 3)
assert.Equal(t, labelMap["amiType"], amiType)
assert.Equal(t, labelMap["capacityType"], capacityType)
assert.Equal(t, labelMap["k8sVersion"], k8sVersion)
}
func TestMoreThen100Groups(t *testing.T) {
a := &autoScalingMock{}
awsWrapper := &awsWrapper{
autoScalingI: a,
ec2I: nil,
eksI: nil,
}
// Generate 101 ASG names
names := make([]string, 101)
for i := 0; i < len(names); i++ {
names[i] = fmt.Sprintf("asg-%d", i)
}
// First batch, first 100 elements
a.On("DescribeAutoScalingGroupsPages",
&autoscaling.DescribeAutoScalingGroupsInput{
AutoScalingGroupNames: aws.StringSlice(names[:100]),
MaxRecords: aws.Int64(maxRecordsReturnedByAPI),
},
mock.AnythingOfType("func(*autoscaling.DescribeAutoScalingGroupsOutput, bool) bool"),
).Run(func(args mock.Arguments) {
fn := args.Get(1).(func(*autoscaling.DescribeAutoScalingGroupsOutput, bool) bool)
fn(testNamedDescribeAutoScalingGroupsOutput("asg-1", 1, "test-instance-id"), false)
}).Return(nil)
// Second batch, element 101
a.On("DescribeAutoScalingGroupsPages",
&autoscaling.DescribeAutoScalingGroupsInput{
AutoScalingGroupNames: aws.StringSlice([]string{"asg-100"}),
MaxRecords: aws.Int64(maxRecordsReturnedByAPI),
},
mock.AnythingOfType("func(*autoscaling.DescribeAutoScalingGroupsOutput, bool) bool"),
).Run(func(args mock.Arguments) {
fn := args.Get(1).(func(*autoscaling.DescribeAutoScalingGroupsOutput, bool) bool)
fn(testNamedDescribeAutoScalingGroupsOutput("asg-2", 1, "test-instance-id"), false)
}).Return(nil)
asgs, err := awsWrapper.getAutoscalingGroupsByNames(names)
assert.Nil(t, err)
assert.Equal(t, len(asgs), 2)
assert.Equal(t, *asgs[0].AutoScalingGroupName, "asg-1")
assert.Equal(t, *asgs[1].AutoScalingGroupName, "asg-2")
}
func TestGetInstanceTypesForAsgs(t *testing.T) {
asgName, ltName, ltVersion, instanceType := "testasg", "launcher", "1", "t2.large"
ltSpec := launchTemplate{
name: ltName,
version: ltVersion,
}
a := &autoScalingMock{}
e := &ec2Mock{}
a.On("DescribeLaunchConfigurations", &autoscaling.DescribeLaunchConfigurationsInput{
LaunchConfigurationNames: []*string{aws.String(ltName)},
MaxRecords: aws.Int64(50),
}).Return(&autoscaling.DescribeLaunchConfigurationsOutput{
LaunchConfigurations: []*autoscaling.LaunchConfiguration{
{
LaunchConfigurationName: aws.String(ltName),
InstanceType: aws.String(instanceType),
},
},
})
e.On("DescribeLaunchTemplateVersions", &ec2.DescribeLaunchTemplateVersionsInput{
LaunchTemplateName: aws.String(ltName),
Versions: []*string{aws.String(ltVersion)},
}).Return(&ec2.DescribeLaunchTemplateVersionsOutput{
LaunchTemplateVersions: []*ec2.LaunchTemplateVersion{
{
LaunchTemplateData: &ec2.ResponseLaunchTemplateData{
InstanceType: aws.String(instanceType),
},
},
},
})
// #1449 Without AWS_REGION getRegion() lookup runs till timeout during tests.
defer resetAWSRegion(os.LookupEnv("AWS_REGION"))
os.Setenv("AWS_REGION", "fanghorn")
awsWrapper := &awsWrapper{
autoScalingI: a,
ec2I: e,
eksI: nil,
}
cases := []struct {
name string
launchConfigurationName string
launchTemplate *launchTemplate
mixedInstancesPolicy *mixedInstancesPolicy
}{
{
"AsgWithLaunchConfiguration",
ltName,
nil,
nil,
},
{
"AsgWithLaunchTemplate",
"",
&ltSpec,
nil,
},
{
"AsgWithLaunchTemplateMixedInstancePolicyOverride",
"",
nil,
&mixedInstancesPolicy{
instanceTypesOverrides: []string{instanceType},
},
},
{
"AsgWithLaunchTemplateMixedInstancePolicyNoOverride",
"",
nil,
&mixedInstancesPolicy{
launchTemplate: &ltSpec,
},
},
}
for _, tc := range cases {
results, err := awsWrapper.getInstanceTypesForAsgs([]*asg{
{
AwsRef: AwsRef{Name: asgName},
LaunchConfigurationName: tc.launchConfigurationName,
LaunchTemplate: tc.launchTemplate,
MixedInstancesPolicy: tc.mixedInstancesPolicy,
},
})
assert.NoError(t, err)
foundInstanceType, exists := results[asgName]
assert.NoErrorf(t, err, "%s had error %v", tc.name, err)
assert.Truef(t, exists, "%s did not find asg", tc.name)
assert.Equalf(t, foundInstanceType, instanceType, "%s had %s, expected %s", tc.name, foundInstanceType, instanceType)
}
}
func TestBuildLaunchTemplateFromSpec(t *testing.T) {
assert := assert.New(t)
units := []struct {
name string
in *autoscaling.LaunchTemplateSpecification
exp *launchTemplate
}{
{
name: "non-default, specified version",
in: &autoscaling.LaunchTemplateSpecification{
LaunchTemplateName: aws.String("foo"),
Version: aws.String("1"),
},
exp: &launchTemplate{
name: "foo",
version: "1",
},
},
{
name: "non-default, specified $Latest",
in: &autoscaling.LaunchTemplateSpecification{
LaunchTemplateName: aws.String("foo"),
Version: aws.String("$Latest"),
},
exp: &launchTemplate{
name: "foo",
version: "$Latest",
},
},
{
name: "specified $Default",
in: &autoscaling.LaunchTemplateSpecification{
LaunchTemplateName: aws.String("foo"),
Version: aws.String("$Default"),
},
exp: &launchTemplate{
name: "foo",
version: "$Default",
},
},
{
name: "no version specified",
in: &autoscaling.LaunchTemplateSpecification{
LaunchTemplateName: aws.String("foo"),
Version: nil,
},
exp: &launchTemplate{
name: "foo",
version: "$Default",
},
},
}
for _, unit := range units {
got := buildLaunchTemplateFromSpec(unit.in)
assert.Equal(unit.exp, got)
}
}