kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5329 from dankenigsberg/patch-1 

tiny whitespace fix
This commit is contained in:
Kubernetes Prow Robot 2020-11-19 08:58:52 -08:00 committed by GitHub
parent 69c5a105d6 7535165e34
commit 018effde89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contributors/guide/pull-requests.md
View File

@ -158,7 +158,7 @@ You send your pull request - this is awesome!
And it sits.
And sits.
A week goes by and nobody reviews it.
Finally, someone offers a few comments, which you fix up and wait for more review.And you wait.
Finally, someone offers a few comments, which you fix up and wait for more review. And you wait.
Another week or two go by. This is horrible.
Let's talk about best practices so your pull request gets reviewed quickly.
@ -607,4 +607,4 @@ That's the last step. Your pull request is now merged.
[area]: https://github.com/kubernetes/kubernetes/labels?q=area
[preferred editor]: https://help.github.com/en/github/using-git/associating-text-editors-with-git
[imperative mood]: https://www.grammar-monster.com/glossary/imperative_mood.htm
[GitHub keywords]: https://help.github.com/articles/closing-issues-using-keywords
[GitHub keywords]: https://help.github.com/articles/closing-issues-using-keywords