Update guidance for becoming an approver
Signed-off-by: Jeremy Rickard <jeremyrrickard@gmail.com>
This commit is contained in:
parent
0b34d32c24
commit
087ca0daeb
|
@ -91,7 +91,7 @@ After serving as reviewer/shadow for at least one release and showing good judge
|
||||||
you can propose yourself as an approver by submitting a PR to add your GitHub
|
you can propose yourself as an approver by submitting a PR to add your GitHub
|
||||||
handle to the `prod-readiness-approvers` alias in [OWNERS_ALIASES].
|
handle to the `prod-readiness-approvers` alias in [OWNERS_ALIASES].
|
||||||
|
|
||||||
When submitting the PR, you should include references to KEPs you reviewed that demonstrated a good variety
|
When submitting the PR, you should include links to your KEP review comments that demonstrate a good variety
|
||||||
of different situations.
|
of different situations.
|
||||||
Here is a good starting point (remember that one PR can cover multiple categories):
|
Here is a good starting point (remember that one PR can cover multiple categories):
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue