update as per review comments

This commit is contained in:
Pravar Agrawal 2021-10-05 21:44:11 +05:30
parent 15f001cdbe
commit 15d2ce6938
1 changed files with 4 additions and 24 deletions

View File

@ -108,30 +108,10 @@ bash variables.
### `verify-bazel` ### `verify-bazel`
This verification script validates whehter the removal of `bazel` This verify-bazel script validates the removal of bazel related
related files is still needed or not. This script after setting the files. The script ensures no bazel related temporary, intermediate or
temporary directories for gopath and kube-related path, runs output files remain as part of
`[update-bazel.sh]()`. And once executed, `update-bazel` deletes all [KEP-2420](https://github.com/kubernetes/enhancements/issues/2420).
the bazel related files which are either not there in vendor and some
additional one-off files. After execution, the `verify-bazel` script
again calculates diff to check the earlier output. And if the diff
result is non-zero then script `update-bazel.sh` is run again for the
files that might be left.
Following are the files that are searched for deletion as part of this
script:
```bash
"${KUBE_ROOT}/build/root/BUILD.root" \
"${KUBE_ROOT}/WORKSPACE" \
"${KUBE_ROOT}/build/root/WORKSPACE" \
"${KUBE_ROOT}/.bazelrc" \
"${KUBE_ROOT}/build/root/.bazelrc" \
"${KUBE_ROOT}/.bazelversion" \
"${KUBE_ROOT}/build/root/.bazelversion" \
"${KUBE_ROOT}/.kazelcfg.json" \
"${KUBE_ROOT}/build/root/.kazelcfg.json"
```
## `verify-boilerplate` ## `verify-boilerplate`