kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5352 from celanthe/patch-3 

Added link to best practices section
This commit is contained in:
Kubernetes Prow Robot 2020-12-07 13:35:11 -08:00 committed by GitHub
parent 599b7547cf ed6f2181ef
commit 4abc0b58dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
contributors/guide/contributing.md
View File

@ -94,10 +94,11 @@ Note: if your pull request isn't getting enough attention, you can use the [#pr-
- Make sure you don't include `@mentions` or `fixes` keywords in your git commit messages. These should be included in the PR body instead. - Make sure you don't include `@mentions` or `fixes` keywords in your git commit messages. These should be included in the PR body instead.
- When you make a PR for small change (such as fixing a typo, style change, or grammar fix), please squash your commits so that we can maintain a cleaner git history. - When you make a PR for small change (such as fixing a typo, style change, or grammar fix), please squash your commits so that we can maintain a cleaner git history.
- Make sure you include a clear and detailed PR description explaining the reasons for the changes, and ensuring there is sufficient information for the reviewer to understand your PR. - Make sure you include a clear and detailed PR description explaining the reasons for the changes, and ensuring there is sufficient information for the reviewer to understand your PR.
- Additional Readings : - Additional Readings:
- [chris.beams.io/posts/git-commit/](https://chris.beams.io/posts/git-commit/) - [chris.beams.io/posts/git-commit/](https://chris.beams.io/posts/git-commit/)
- [github.com/blog/1506-closing-issues-via-pull-requests ](https://github.com/blog/1506-closing-issues-via-pull-requests ) - [github.com/blog/1506-closing-issues-via-pull-requests ](https://github.com/blog/1506-closing-issues-via-pull-requests)
- [davidwalsh.name/squash-commits-git ](https://davidwalsh.name/squash-commits-git ) - [davidwalsh.name/squash-commits-git ](https://davidwalsh.name/squash-commits-git)
- [https://mtlynch.io/code-review-love/](https://mtlynch.io/code-review-love/)
## Testing ## Testing