From 5c71e1f461fce9eea5733e71558814a5587555b6 Mon Sep 17 00:00:00 2001 From: sivchari Date: Wed, 7 Feb 2024 18:57:01 +0900 Subject: [PATCH] revise from reflect.Equal to reflect.DeepEqual Signed-off-by: sivchari --- sig-scheduling/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sig-scheduling/CONTRIBUTING.md b/sig-scheduling/CONTRIBUTING.md index 1584b9ec0..89b003d4e 100644 --- a/sig-scheduling/CONTRIBUTING.md +++ b/sig-scheduling/CONTRIBUTING.md @@ -104,7 +104,7 @@ Testing: should be considered for critical and/or CPU intensive operations. - General guidelines: - Follow a [DAMP principle](https://stackoverflow.com/a/11837973). - - Use `cmp.Diff` instead of `reflect.Equal`, to provide useful comparisons. + - Use `cmp.Diff` instead of `reflect.DeepEqual`, to provide useful comparisons. - Compare errors using `errors.Is` (`cmpopts.EquateErrors` when using `cmp.Diff`) instead of comparing the error strings. - Leverage existing utility functions from `pkg/scheduler/testing`.