kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Renaming to `Best Practices`

This commit is contained in:
vishakha 2019-12-26 07:22:29 +05:30 committed by GitHub
parent 497de1e4bf
commit 602f150a52
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contributors/guide/README.md
View File

@ -36,7 +36,7 @@ Welcome to Kubernetes!
- [GitHub workflow](#github-workflow)
- [Open a Pull Request](#open-a-pull-request)
- [Code Review](#code-review)
- [Contributions best practices](#contributions-best-practices)
- [Best Practices](#best-practices)
- [Testing](#testing)
- [Security](#security)
- [Documentation](#documentation)
@ -235,7 +235,7 @@ When reviewing PRs from others [The Gentle Art of Patch Review](http://sage.thes
Note: if your pull request isn't getting enough attention, you can use the [#pr-reviews](https://kubernetes.slack.com/messages/pr-reviews) channel on Slack to get help finding reviewers.
## Contributions best practices
## Best practices
- Write clear and meaningful git commit messages.
- If the PR will *completely* fix a specific issue, include `fixes #123` in the PR body (where 123 is the specific issue number the PR will fix. This will automatically close the issue when the PR is merged.