kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7706 from sivchari/fix-incorrect-function-name 

revise from reflect.Equal to reflect.DeepEqual
This commit is contained in:
Kubernetes Prow Robot 2024-04-08 23:56:03 -07:00 committed by GitHub
parent 49c52eac43 5c71e1f461
commit 60f3c93a0b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sig-scheduling/CONTRIBUTING.md
View File

@ -104,7 +104,7 @@ Testing:
should be considered for critical and/or CPU intensive operations.
- General guidelines:
- Follow a [DAMP principle](https://stackoverflow.com/a/11837973).
- Use `cmp.Diff` instead of `reflect.Equal`, to provide useful comparisons.
- Use `cmp.Diff` instead of `reflect.DeepEqual`, to provide useful comparisons.
- Compare errors using `errors.Is` (`cmpopts.EquateErrors` when using
`cmp.Diff`) instead of comparing the error strings.
- Leverage existing utility functions from `pkg/scheduler/testing`.