kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3254 from BenTheElder/deps-reviews 

add some more details to reviewing godeps
This commit is contained in:
Kubernetes Prow Robot 2019-02-13 11:21:42 -08:00 committed by GitHub
parent 5bb9b98917 aef7689a46
commit 612fa3ee40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
contributors/devel/sig-architecture/godep.md
View File

@ -244,6 +244,16 @@ When importing a new dependency, be sure to keep an eye out for the following:
- Does the dependency have a license that is compatible with the Kubernetes
project?
Additionally:
- Look at the godeps file. Check that the only changes are what the PR claims
them to be.
- Check if there is a tagged release we can vendor instead of a random hash
- Scan the imported code for things like init() functions
- Look at the Kubernetes code changes and make sure they are appropriate
(e.g. renaming imports or similar). You do not need to do feature code review.
- If this is all good, approve, but don't LGTM, unless you also do code review
or unless it is trivial (e.g. moving from k/k/pkg/utils -> k/utils).
All new dependency licenses should be reviewed by either Tim Hockin (@thockin)
or the Steering Committee (@kubernetes/steering-committee) to ensure that they
are compatible with the Kubernetes project license. It is also important to note