kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1298 from php-coder/improve_api_changes 

Automatic merge from submit-queue.

api_changes.md: update place with list of packages for protobuf

After renaming `k8s.io/kube-gen` package, the instruction got dated. As far I understand, now we need to modify `hack/update-generated-protobuf-dockerized.sh` script. This PR updates the instruction.

PTAL @sttts 
CC @simo5
This commit is contained in:
Kubernetes Submit Queue 2017-10-30 11:53:57 -07:00 committed by GitHub
parent a0d81523e3 251f432481
commit 64a16be6e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contributors/devel/api_changes.md
View File

@ -595,7 +595,7 @@ Due to the fast changing nature of the project, the following content is probabl
* You must add the new version to
[hack/lib/init.sh#KUBE_AVAILABLE_GROUP_VERSIONS](https://github.com/kubernetes/kubernetes/blob/v1.8.0-alpha.2/hack/lib/init.sh#L53).
* You must add the new version to
[staging/src/k8s.io/kube-gen/cmd/go-to-protobuf/protobuf/cmd.go](https://github.com/kubernetes/kubernetes/blob/2e6be8583d00916f1896d2b53e550162f1558ccf/staging/src/k8s.io/kube-gen/cmd/go-to-protobuf/protobuf/cmd.go#L64)
[hack/update-generated-protobuf-dockerized.sh](https://github.com/kubernetes/kubernetes/blob/v1.8.2/hack/update-generated-protobuf-dockerized.sh#L44)
to generate protobuf IDL and marshallers.
* You must add the new version to
[cmd/kube-apiserver/app#apiVersionPriorities](https://github.com/kubernetes/kubernetes/blob/v1.8.0-alpha.2/cmd/kube-apiserver/app/aggregator.go#L172)