kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[squash] Add feature gate

This commit is contained in:
Jan Safranek 2017-08-01 12:46:34 +02:00
parent baf0dcb0bd
commit 67cd544372
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
contributors/design-proposals/propagation.md
View File

@ -162,8 +162,8 @@ and something prevents it from starting if `/sys` is shared.
## Decision ## Decision
* We will take 'Add an option in VolumeMount API' (with an annotation during * We will take 'Add an option in VolumeMount API'
alpha instead of real VolumeMount field): * With an alpha feature gate in 1.8.
* With validation that it can be used only with HostPath volumes. * With validation that it can be used only with HostPath volumes.
* With validation that shared propagation can be used only in privileged * With validation that shared propagation can be used only in privileged
containers. containers.
@ -181,13 +181,11 @@ and something prevents it from starting if `/sys` is shared.
* Node conformance suite will check that mount propagation in /var/lib/kubelet * Node conformance suite will check that mount propagation in /var/lib/kubelet
works. works.
* During alpha, all the behavior above must be explicitly enabled by * During alpha, all the behavior above must be explicitly enabled by
`kubelet --experimental-enable-mount-propagation` `kubelet --feature-gates=MountPropagation=true`
It will be used only for testing of volume plugins in e2e tests and It will be used only for testing of volume plugins in e2e tests and
it will be marked as deprecated from the beginning.
Developers / testers can enable it in their clusters manually.
Mount propagation may be redesigned or even removed in any future release. Mount propagation may be redesigned or even removed in any future release.
* The default mount propagation will be `rslave`, which is different to current * When the feature is enabled the default mount propagation will be `rslave`,
`private`. Extensive testing is needed! which is different to current `private`. Extensive testing is needed!
## Extra Concerns ## Extra Concerns
@ -215,7 +213,7 @@ if a pod does not create any new mountpoints under its hostpath bindmount, it's
not hard to reach multiplicative explosions with shared bindmounts and so the not hard to reach multiplicative explosions with shared bindmounts and so the
change in default + no cleanup could result in existing workloads knocking the change in default + no cleanup could result in existing workloads knocking the
node over. node over.
These concerns are valid and we decide to limit the propagation mode to HostPath These concerns are valid and we decide to limit the propagation mode to HostPath
volume only, in HostPath, we expect any runtime should NOT perform any additional volume only, in HostPath, we expect any runtime should NOT perform any additional
actions (such as clean up). This behavior is also consistent with current HostPath actions (such as clean up). This behavior is also consistent with current HostPath