kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allow verify-generated-docs to use go modcache 

I don't think we need to use an entirely separate GOPATH, thus forcing
us to re-download modules every time we run `make`

This was causing verify-generated-docs to fail locally since go will
set its modcache as readonly and thus cause the cleanup "rm -rf" in
this script to fail. In go1.14 or later we could use "-modcacherw"
to stop making the modcache readonly but that bring me back to.. why
do need an entirely separate GOPATH in the first place?
This commit is contained in:
Aaron Crickenberger 2020-08-18 16:47:51 -07:00
parent 7fdf3b2df4
commit 6d0c920003
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/verify-generated-docs.sh
View File

@ -21,7 +21,6 @@ set -o pipefail
CRT_DIR=$(pwd) CRT_DIR=$(pwd)
VERIFY_TEMP=$(mktemp -d 2>/dev/null || mktemp -d -t k8s-community.XXXXXX) VERIFY_TEMP=$(mktemp -d 2>/dev/null || mktemp -d -t k8s-community.XXXXXX)
WORKING_DIR="${VERIFY_TEMP}/src/testgendocs" WORKING_DIR="${VERIFY_TEMP}/src/testgendocs"
GOPATH="${VERIFY_TEMP}"
mkdir -p "${WORKING_DIR}" mkdir -p "${WORKING_DIR}"
function cleanup { function cleanup {