kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tiny whitespace fix 

For the more compulsive among us, let's have a space just before a sentence begins.
This commit is contained in:
Dan Kenigsberg 2020-11-19 00:27:16 +02:00 committed by GitHub
parent 69c5a105d6
commit 7535165e34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contributors/guide/pull-requests.md
View File

@ -158,7 +158,7 @@ You send your pull request - this is awesome!
And it sits. And it sits.
And sits. And sits.
A week goes by and nobody reviews it. A week goes by and nobody reviews it.
Finally, someone offers a few comments, which you fix up and wait for more review.And you wait. Finally, someone offers a few comments, which you fix up and wait for more review. And you wait.
Another week or two go by. This is horrible. Another week or two go by. This is horrible.
Let's talk about best practices so your pull request gets reviewed quickly. Let's talk about best practices so your pull request gets reviewed quickly.
@ -607,4 +607,4 @@ That's the last step. Your pull request is now merged.
[area]: https://github.com/kubernetes/kubernetes/labels?q=area [area]: https://github.com/kubernetes/kubernetes/labels?q=area
[preferred editor]: https://help.github.com/en/github/using-git/associating-text-editors-with-git [preferred editor]: https://help.github.com/en/github/using-git/associating-text-editors-with-git
[imperative mood]: https://www.grammar-monster.com/glossary/imperative_mood.htm [imperative mood]: https://www.grammar-monster.com/glossary/imperative_mood.htm
[GitHub keywords]: https://help.github.com/articles/closing-issues-using-keywords [GitHub keywords]: https://help.github.com/articles/closing-issues-using-keywords