From 21831698d5acd7c74e2b3480ba1bbb9e8c453a18 Mon Sep 17 00:00:00 2001 From: knight <1004815462@qq.com> Date: Tue, 5 Feb 2019 14:24:42 +0800 Subject: [PATCH 1/2] fix wrong words --- contributors/design-proposals/apps/deployment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contributors/design-proposals/apps/deployment.md b/contributors/design-proposals/apps/deployment.md index 3f7571445..b51e24886 100644 --- a/contributors/design-proposals/apps/deployment.md +++ b/contributors/design-proposals/apps/deployment.md @@ -131,8 +131,8 @@ type DeploymentStatus struct { The DeploymentController will process Deployments and crud ReplicaSets. For each creation or update for a Deployment, it will: -1. Find all RSs (ReplicaSets) whose label selector is a superset of DeploymentSpec.Selector. - - For now, we will do this in the client - list all RSs and then filter the +1. Find all RSs (ReplicaSets) whose label selector is a subset of DeploymentSpec.Selector. + - For now, we will do this in the client - list all RSs and then filter out the ones we want. Eventually, we want to expose this in the API. 2. The new RS can have the same selector as the old RS and hence we add a unique selector to all these RSs (and the corresponding label to their pods) to ensure From 8f9065157294b4935c6a42800230bdb7a12df41a Mon Sep 17 00:00:00 2001 From: knight <1004815462@qq.com> Date: Tue, 5 Feb 2019 14:31:32 +0800 Subject: [PATCH 2/2] Update deployment.md --- contributors/design-proposals/apps/deployment.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contributors/design-proposals/apps/deployment.md b/contributors/design-proposals/apps/deployment.md index b51e24886..30392c4a1 100644 --- a/contributors/design-proposals/apps/deployment.md +++ b/contributors/design-proposals/apps/deployment.md @@ -131,7 +131,7 @@ type DeploymentStatus struct { The DeploymentController will process Deployments and crud ReplicaSets. For each creation or update for a Deployment, it will: -1. Find all RSs (ReplicaSets) whose label selector is a subset of DeploymentSpec.Selector. +1. Find all RSs (ReplicaSets) whose label selector is a superset of DeploymentSpec.Selector. - For now, we will do this in the client - list all RSs and then filter out the ones we want. Eventually, we want to expose this in the API. 2. The new RS can have the same selector as the old RS and hence we add a unique @@ -153,7 +153,7 @@ For each creation or update for a Deployment, it will: is same as hash of DeploymentSpec.PodTemplateSpec. If it exists already, then this is the RS that will be ramped up. If there is no such RS, then we create a new one using DeploymentSpec and then add a "pod-template-hash" label - to it. The size of the new RS depends on the used DeploymentStrategyType + to it. The size of the new RS depends on the used DeploymentStrategyType. 4. Scale up the new RS and scale down the olds ones as per the DeploymentStrategy. Raise events appropriately (both in case of failure or success). 5. Go back to step 1 unless the new RS has been ramped up to desired replicas