kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7305 from deads2k/ladder 

add details for becoming a PRR approver
This commit is contained in:
Kubernetes Prow Robot 2023-11-20 20:20:21 +01:00 committed by GitHub
parent 421b880427 887d371e40
commit 79737aab95
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
sig-architecture/production-readiness.md
View File

@ -84,10 +84,29 @@ To become a reviewer:
* Read/study previous PRR comments and production readiness responses in existing KEPs. * Read/study previous PRR comments and production readiness responses in existing KEPs.
* Choose some KEPs requiring PRR and perform a review. Put "shadow prod readiness review" * Choose some KEPs requiring PRR and perform a review. Put "shadow prod readiness review"
in your review comments so that the assigned PRR approver knows your intent. in your review comments so that the assigned PRR approver knows your intent.
* After at least one release cycle, if you have shown good judgement and quality reviews,
you can propose yourself as approver by submitting a PRR to add your GitHub ### Becoming an approver
After serving as reviewer/shadow for at least one release and showing good judgement and quality reviews,
you can propose yourself as an approver by submitting a PR to add your GitHub
handle to the `prod-readiness-approvers` alias in [OWNERS_ALIASES]. handle to the `prod-readiness-approvers` alias in [OWNERS_ALIASES].
When submitting the PR, you should include references to KEPs you reviewed that demonstrated a good variety
of different situations.
Here is a good starting point (remember that one PR can cover multiple categories):
* Transitions from new to alpha
* Transitions from alpha to beta
* Transitions from beta to GA
* Must have successfully reviewed at least three enhancements that require coordination between multiple components.
* Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew):
does behavior fail safely and eventually reconcile.
* Must have successfully reviewed at least three enhancements that are outside your primary domain.
* Examples where the feature requires considering the case of administering thousands of clusters.
This comes up frequently for host-based features in storage, node, or networking.
* Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.
## Finding KEPs needing prod readiness review ## Finding KEPs needing prod readiness review
The prod readiness team uses the [kepctl query] command line tool to identify KEP PRs The prod readiness team uses the [kepctl query] command line tool to identify KEP PRs