kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improving the PR Template and Contributor-Cheatsheet

This commit is contained in:
vishakha 2019-12-19 05:17:55 +05:30
parent 533a66caf6
commit 7ff65be38c
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -4,4 +4,12 @@
You will need to follow these steps: You will need to follow these steps:
1. Edit sigs.yaml with your change 1. Edit sigs.yaml with your change
2. Generate docs with `make generate`. To build docs for one sig, run `make WHAT=sig-apps generate` 2. Generate docs with `make generate`. To build docs for one sig, run `make WHAT=sig-apps generate`
--> -->
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

5
contributors/guide/contributor-cheatsheet/README.md
View File

@ -332,12 +332,13 @@ remotes.
#### Keeping Your Fork in Sync #### Keeping Your Fork in Sync
Fetch all the changes from `upstream` and _"rebase"_ them on your local `master` Fetch all the changes from `upstream` and _"rebase"_ them on your local `master`
branch. This will sync your local repo with the `upstream` project. branch. This will sync your local repo with the `upstream` project. Push the local changes to your `remote master`.
``` ```
git fetch upstream git fetch upstream
git checkout master git checkout master
git rebase upstream/master git rebase upstream/master
git push
``` ```
You should do this minimally before creating a new branch to work on your You should do this minimally before creating a new branch to work on your
@ -403,4 +404,4 @@ the other contributors assigned to review and approve your PR.
[Security and Disclosure Information]: https://kubernetes.io/docs/reference/issues-security/security/ [Security and Disclosure Information]: https://kubernetes.io/docs/reference/issues-security/security/
[approve]: https://prow.k8s.io/command-help#approve [approve]: https://prow.k8s.io/command-help#approve
[GitHub Administration Team]: /github-management#github-administration-team [GitHub Administration Team]: /github-management#github-administration-team
[Kubernetes Patch Release]: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md [Kubernetes Patch Release]: https://github.com/kubernetes/sig-release/blob/master/releases/patch-releases.md