kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3643 from liggitt/api-review-validation 

Add field/validation/behavior change to API review requirements
This commit is contained in:
Kubernetes Prow Robot 2019-09-06 13:37:20 -07:00 committed by GitHub
parent 55907d2f4e 4add2dbfd2
commit 81ec4af0ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sig-architecture/api-review-process.md
View File

@ -72,6 +72,7 @@ Voluntary reviews apply towards non-core APIs that do not meet the [mandatory](#
* Any new resource type
* Any new version of a stable API
* Any new functionality added to a stable API as defined by SIG Architecture and the API Reviewers
* Any change to the meaning, validation, or behavior of a field
* The existing [API conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md) (and [API change guidelines](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md), if applicable) have been read and followed.
1. Request an API review for a PR or issue in the kubernetes org by adding the `api-review` label with a `/label api-review` comment (requests can be cancelled with a `/remove-label api-review` comment)