Merge pull request #1763 from lijianfeng1993/fix_some_duplication_problems

fix some duplication problems in api-machinery
This commit is contained in:
k8s-ci-robot 2018-02-08 19:14:51 -08:00 committed by GitHub
commit 88d7f28286
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions

View File

@ -66,7 +66,7 @@ updates could be overly chatty.
By porting OpenShift's
[LeaseEndpointReconciler](https://github.com/openshift/origin/blob/master/pkg/cmd/server/election/lease_endpoint_reconciler.go)
to Kubernetes we can use use the Storage API directly to store Endpoints
to Kubernetes we can use the Storage API directly to store Endpoints
dynamically within the system.
### Alternate Proposals

View File

@ -470,7 +470,7 @@ be send multiple times, once over each channel, here it would be send once)
- we would have to introduce a dedicate "BulkWatchEvent" type to incorporate
resource type. This would make those two incompatible even at the output format.
With all of those in mind, even though the implementation would be much much
With all of those in mind, even though the implementation would be much
simpler (and could potentially be a first step and would probably solve the
original "kubelet watching secrets" problem good enough), we decided not to
proceed with it at all.

View File

@ -157,7 +157,7 @@ show-kind | Implement client-side by using the discovery info associated with th
template | Implement client-side, bypass receiving table output and get raw objects
watch | Request Table output via the watch endpoint
export | Implement client-side, bypass receiving table output and get exported object
wide | Server should indicate which columns are "additional" via a field on on the header column - client then shows those columns if it wants to
wide | Server should indicate which columns are "additional" via a field on the header column - client then shows those columns if it wants to
color (proposed) | Rows which should be highlighted should have a semantic field on the row - e.g. `alert: [{type: Warning, message: "This pod has been deleted"}]`. Cells could be selected by adding an additional field `alert: [{type: Warning, ..., cells: [0, 1]}]`.