From 973df9cfd8f4589bae610d1efca58cd944811630 Mon Sep 17 00:00:00 2001 From: Tim Hockin Date: Tue, 3 May 2016 22:00:27 -0700 Subject: [PATCH] Get rid of hack/after-build scripts The build is now fast enough to not need them. --- adding-an-APIGroup.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/adding-an-APIGroup.md b/adding-an-APIGroup.md index 2b3188284..e0f95fc77 100644 --- a/adding-an-APIGroup.md +++ b/adding-an-APIGroup.md @@ -50,8 +50,8 @@ We plan on improving the way the types are factored in the future; see in which this might evolve. 1. Create a folder in pkg/apis to hold you group. Create types.go in - pkg/apis/``/ and pkg/apis/``/``/ to define API objects - in your group; +pkg/apis/``/ and pkg/apis/``/``/ to define API objects +in your group; 2. Create pkg/apis/``/{register.go, ``/register.go} to register this group's API objects to the encoding/decoding scheme (e.g., @@ -75,10 +75,10 @@ cmd/libs/go2idl/ tool. 1. Generate conversions and deep-copies: 1. Add your "group/" or "group/version" into -cmd/libs/go2idl/{conversion-gen, deep-copy-gen}/main.go; + cmd/libs/go2idl/{conversion-gen, deep-copy-gen}/main.go; 2. Make sure your pkg/apis/``/`` directory has a doc.go file -with the comment `// +genconversion=true`, to catch the attention of our -gen-conversion script. + with the comment `// +genconversion=true`, to catch the attention of our + gen-conversion script. 3. Run hack/update-all.sh. @@ -89,7 +89,8 @@ gen-conversion script. 3. Generate protobuf objects: - 1. Add your group to `cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go` to `New()` in the `Packages` field + 1. Add your group to `cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go` to + `New()` in the `Packages` field 2. Run hack/update-generated-protobuf.sh ### Client (optional):