kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

generator: don't specify company for emeritus_leads 

If we end up specifying the company for emeritus leads, we could end
up stale information. Moreover, we don't gain any specific value
from company info of emeritus leads.
This commit is contained in:
Nikhita Raghunath 2019-09-27 13:02:27 +05:30
parent 395d34e5c8
commit a0055b5063
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
generator/app.go
View File

@ -68,7 +68,7 @@ func (x FoldedString) MarshalYAML() (interface{}, error) {
type Person struct { type Person struct {
GitHub string GitHub string
Name string Name string
Company string Company string `yaml:"company,omitempty"`
} }
// Meeting represents a regular meeting for a group. // Meeting represents a regular meeting for a group.
@ -233,12 +233,16 @@ func (c *Context) Validate() []error {
for prefix, persons := range group.Leadership.PrefixToPersonMap() { for prefix, persons := range group.Leadership.PrefixToPersonMap() {
for _, person := range persons { for _, person := range persons {
if val, ok := people[person.GitHub]; ok { if val, ok := people[person.GitHub]; ok {
if val.Name != person.Name || val.Company != person.Company { if val.Name != person.Name || (prefix != "emeritus_lead" && val.Company != person.Company) {
errors = append(errors, fmt.Errorf("%s: %ss: expected person: %v, got: %v", group.Dir, prefix, val, person)) errors = append(errors, fmt.Errorf("%s: %ss: expected person: %v, got: %v", group.Dir, prefix, val, person))
} }
} else { } else if prefix != "emeritus_lead" {
people[person.GitHub] = person people[person.GitHub] = person
} }
if prefix == "emeritus_lead" && person.Company != "" {
errors = append(errors, fmt.Errorf("%s: emeritus leads should not have company specified; company specified for: %s", group.Dir, person.Name))
}
} }
} }
if len(group.StakeholderSIGs) != 0 { if len(group.StakeholderSIGs) != 0 {