From a095f16dc8de303eb8ae104a231b8ab85a5a76d9 Mon Sep 17 00:00:00 2001 From: ramnar Date: Tue, 5 Feb 2019 20:14:42 +0530 Subject: [PATCH] Broken Links fix for 2696 (#3171) * broken links fix in kubernetes community * Broken Links bug fix * Implemented Review Comments * Implemented Review Comments --- contributors/guide/github-workflow.md | 6 +----- sig-azure/charter.md | 2 +- sig-multicluster/CONTRIBUTING.md | 4 ++-- sig-storage/contributing.md | 2 +- 4 files changed, 5 insertions(+), 9 deletions(-) diff --git a/contributors/guide/github-workflow.md b/contributors/guide/github-workflow.md index cc1e7e8f0..cef4e0a39 100644 --- a/contributors/guide/github-workflow.md +++ b/contributors/guide/github-workflow.md @@ -199,7 +199,7 @@ git push -f ${your_remote_name} myfeature ### 7 Create a pull request -1. Visit your fork at https://github.com/$user/kubernetes +1. Visit your fork at `https://github.com/$user/kubernetes` 2. Click the `Compare & Pull Request` button next to your `myfeature` branch. 3. Check out the pull request [process](/contributors/guide/pull-requests.md) for more details and advice. @@ -219,10 +219,6 @@ Commit changes made in response to review comments to the same branch on your fork. Very small PRs are easy to review. Very large PRs are very difficult to review. -At the assigned reviewer's discretion, a PR may be switched to use -[Reviewable](https://reviewable.k8s.io) instead. Once a PR is switched to -Reviewable, please ONLY send or reply to comments through Reviewable. Mixing -code review tools can be very confusing. #### Squash and Merge diff --git a/sig-azure/charter.md b/sig-azure/charter.md index 87f0324ff..94df040fc 100644 --- a/sig-azure/charter.md +++ b/sig-azure/charter.md @@ -97,4 +97,4 @@ Issues impacting multiple subprojects in the SIG should be resolved by SIG Techn [super-majority]: https://en.wikipedia.org/wiki/Supermajority#Two-thirds_vote [KEP]: https://github.com/kubernetes/community/blob/master/keps/0000-kep-template.md [sigs.yaml]: https://github.com/kubernetes/community/blob/master/sigs.yaml#L1454 -[OWNERS]: contributors/devel/owners.md +[OWNERS]: /contributors/guide/owners.md diff --git a/sig-multicluster/CONTRIBUTING.md b/sig-multicluster/CONTRIBUTING.md index 91e23214f..ffb2dc5d7 100644 --- a/sig-multicluster/CONTRIBUTING.md +++ b/sig-multicluster/CONTRIBUTING.md @@ -275,8 +275,8 @@ See the sig-multicluster [community page] for points of contact and meeting time [community page]: /sig-multicluster [contributors guide]: /contributors/guide [design proposal]: #design-proposals -[design repo]: /contributors/design-proposals/sig-multicluster -[design template]: /contributors/design-proposals/sig-multicluster/template.md +[design repo]: /contributors/design-proposals/multicluster +[design template]: /contributors/design-proposals/Design_Proposal_TEMPLATE.md [development guide]: /contributors/devel/development.md [existing issue]: #adopt-an-issue [feature repo]: https://github.com/kubernetes/features diff --git a/sig-storage/contributing.md b/sig-storage/contributing.md index 2e275e127..7d85fe7d1 100644 --- a/sig-storage/contributing.md +++ b/sig-storage/contributing.md @@ -40,7 +40,7 @@ For folks looking to add support for a new storage platform in Kubernetes, you h - Write an in-tree volume plugin or provisioner: You can contribute a new in-tree volume plugin or provisioner, that gets built and ships with Kubernetes, for use within the Persistent Volume Framework. [See the Ceph RBD volume plugin example](https://git.k8s.io/kubernetes/pkg/volume/rbd) or [the AWS Provisioner example](https://github.com/kubernetes/kubernetes/pull/29006) - Write a FlexVolume plugin: This is an out-of-tree volume plugin which you develop and build separately outside of Kubernetes. -You then install the plugin on every Kubernetes host within your cluster and then [configure the plugin in Kubernetes as a FlexVolume](https://git.k8s.io/kubernetes/examples/volumes/flexvolume) +You then install the plugin on every Kubernetes host within your cluster and then [configure the plugin in Kubernetes as a FlexVolume](https://git.k8s.io/examples/staging/volumes/flexvolume) - Write a Provisioner Controller: You can write a separate controller that watches for pending claims with a specific selector label on them. Once an appropriate claim is discovered, the controller then provisions the appropriate storage intended for the claim and creates a corresponding persistent volume for the claim that includes the same label used in the original claim selector. This will ensure that the PV for the new