kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1295 from gin419/patch-1 

Automatic merge from submit-queue.

Update cloudprovider-storage-metrics.md fix wrong words
This commit is contained in:
Kubernetes Submit Queue 2017-10-30 01:07:44 -07:00 committed by GitHub
parent 28d88b385d 7e448cbe6a
commit a0d81523e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contributors/design-proposals/cloud-provider/cloudprovider-storage-metrics.md
View File

@ -13,7 +13,7 @@ we will implement metrics for:
* AWS * AWS
We will also implement metrics only for storage API calls for now. This feature We will also implement metrics only for storage API calls for now. This feature
does introduces hooks into kubernetes code which can be used to add additonal metrics does introduces hooks into kubernetes code which can be used to add additional metrics
but we only focus on storage API calls here. but we only focus on storage API calls here.
## Motivation ## Motivation
@ -50,7 +50,7 @@ the external Cloud Provider - we will use [Histogram](https://prometheus.io/docs
emitting these metrics. emitting these metrics.
We will be using `HistogramVec` type so as we can attach dimensions at runtime. All metrics will contain API action We will be using `HistogramVec` type so as we can attach dimensions at runtime. All metrics will contain API action
being taken as a dimension. The cloudprovider maintainer may choose to add additonal dimensions as needed. If a being taken as a dimension. The cloudprovider maintainer may choose to add additional dimensions as needed. If a
dimension is not available at point of emission sentinel value `<n/a>` should be emitted as a placeholder. dimension is not available at point of emission sentinel value `<n/a>` should be emitted as a placeholder.
We are also interested in counter of cloudprovider API errors. `NewCounterVec` type will be used for keeping We are also interested in counter of cloudprovider API errors. `NewCounterVec` type will be used for keeping