Merge pull request #4179 from wojtek-t/remove_references_to_initializers

Remove references to initializers in SLOs
This commit is contained in:
Kubernetes Prow Robot 2019-10-21 00:25:37 -07:00 committed by GitHub
commit c1cbc409e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 10 deletions

View File

@ -27,15 +27,15 @@ namespaces.
- As a user of vanilla Kubernetes, I want some guarantee how quickly I get the - As a user of vanilla Kubernetes, I want some guarantee how quickly I get the
response from an API call. response from an API call.
- As an administrator of Kubernetes cluster, if I know characteristics of my - As an administrator of Kubernetes cluster, if I know characteristics of my
external dependencies of apiserver (e.g custom admission plugins, webhooks and external dependencies of apiserver (e.g custom admission plugins and webhooks)
initializers) I want to be able to provide guarantees for API calls latency to I want to be able to provide guarantees for API calls latency to users of my
users of my cluster. cluster.
### Other notes ### Other notes
- We obviously cant give any guarantee in general, because cluster - We obviously cant give any guarantee in general, because cluster
administrators are allowed to register custom admission plugins, webhooks administrators are allowed to register custom admission plugins or webhooks,
and/or initializers, which we dont have any control about and they obviously which we dont have any control about and they obviously impact API call
impact API call latencies. latencies.
- As a result, we define the SLIs to be very generic (no matter how your - As a result, we define the SLIs to be very generic (no matter how your
cluster is set up), but we provide SLO only for default installations (where we cluster is set up), but we provide SLO only for default installations (where we
have control over what apiserver is doing). This doesnt provide a false have control over what apiserver is doing). This doesnt provide a false

View File

@ -6,9 +6,8 @@
| --- | --- | | --- | --- |
| WIP | Admission latency for each admission plugin type, measured as 99th percentile over last 5 minutes | | WIP | Admission latency for each admission plugin type, measured as 99th percentile over last 5 minutes |
| WIP | Webhook call latency for each webhook type, measured as 99th percentile over last 5 minutes | WIP | Webhook call latency for each webhook type, measured as 99th percentile over last 5 minutes
| WIP | Initializer latency for each initializer, measured as 99th percentile over last 5 minutes |
### User stories ### User stories
- As an administrator, if API calls are slow, I would like to know if this is - As an administrator, if API calls are slow, I would like to know if this is
because slow extension points (admission plugins, webhooks, initializers) and because slow extension points (admission plugins, webhooks) and if so which ones
if so which ones are responsible for it. are responsible for it.

View File

@ -135,5 +135,4 @@ sliding window. However, for the purpose of SLO itself, it basically means
| WIP | Watch latency for every resource, (from the moment when object is stored in database to when it's ready to be sent to all watchers), measured as 99th percentile over last 5 minutes | [Details](./watch_latency.md) | | WIP | Watch latency for every resource, (from the moment when object is stored in database to when it's ready to be sent to all watchers), measured as 99th percentile over last 5 minutes | [Details](./watch_latency.md) |
| WIP | Admission latency for each admission plugin type, measured as 99th percentile over last 5 minutes | [Details](./api_extensions_latency.md) | | WIP | Admission latency for each admission plugin type, measured as 99th percentile over last 5 minutes | [Details](./api_extensions_latency.md) |
| WIP | Webhook call latency for each webhook type, measured as 99th percentile over last 5 minutes | [Details](./api_extensions_latency.md) | | WIP | Webhook call latency for each webhook type, measured as 99th percentile over last 5 minutes | [Details](./api_extensions_latency.md) |
| WIP | Initializer latency for each initializer, measured as 99th percentile over last 5 minutes | [Details](./api_extensions_latency.md) |