kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1695 from guineveresaenger/brokenlink 

fixed links to community expectations
This commit is contained in:
k8s-ci-robot 2018-01-26 08:21:31 -08:00 committed by GitHub
parent ca503d1549 ec8afcb362
commit c41473c9d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -49,7 +49,7 @@ Links in [contributors/devel/README.md](contributors/devel/README.md)
lead to many relevant topics, including lead to many relevant topics, including
* [Developer's Guide] - how to start a build/test cycle * [Developer's Guide] - how to start a build/test cycle
* [Collaboration Guide] - how to work together * [Collaboration Guide] - how to work together
* [expectations] - what the community expects * [expectations](contributors/guide/community-expectations) - what the community expects
* [pull request] policy - how to prepare a pull request * [pull request] policy - how to prepare a pull request
## Your First Contribution ## Your First Contribution

2
community-membership.md
View File

@ -185,7 +185,7 @@ The following apply to the part of codebase for which one would be an approver i
- Demonstrate sound technical judgement - Demonstrate sound technical judgement
- Responsible for project quality control via [code reviews](contributors/devel/collab.md) - Responsible for project quality control via [code reviews](contributors/devel/collab.md)
- Focus on holistic acceptance of contribution such as dependencies with other features, backwards / forwards compatibility, API and flag definitions, etc - Focus on holistic acceptance of contribution such as dependencies with other features, backwards / forwards compatibility, API and flag definitions, etc
- Expected to be responsive to review requests as per [community expectations](contributors/devel/community-expectations.md); - Expected to be responsive to review requests as per [community expectations](contributors/guide/community-expectations.md);
- Mentor contributors and reviewers - Mentor contributors and reviewers
- May approve code contributions for acceptance - May approve code contributions for acceptance

2
contributors/guide/README.md
View File

@ -152,7 +152,7 @@ The pull request workflow is described in detail [here](/contributors/devel/pull
## Code Review ## Code Review
For a brief description of the importance of code review, please read [On Code Review](/contributors/devel/community-expectations.md#code-review). There are two aspects of code review: giving and receiving. For a brief description of the importance of code review, please read [On Code Review](/contributors/guide/community-expectations.md#code-review). There are two aspects of code review: giving and receiving.
To make it easier for your PR to receive reviews, consider the reviewers will need you to: To make it easier for your PR to receive reviews, consider the reviewers will need you to:

2
mentoring/group-mentee-guide.md
View File

@ -66,7 +66,7 @@ Suggested Activity
- the docs - the docs
- k/community is your friend for upstream workflows, processes, and information around contributing - k/community is your friend for upstream workflows, processes, and information around contributing
- This repo includes the community/devel folder which will be extra helpful that includes docs such as: - This repo includes the community/devel folder which will be extra helpful that includes docs such as:
- [Code Review Expectations](/contributors/devel/community-expectations.md) - [Code Review Expectations](/contributors/guide/community-expectations.md)
- [Collaboration on k8s](/contributors/devel/collab.md) - [Collaboration on k8s](/contributors/devel/collab.md)