From 7fdf3b2df4701729df3bb09859b8aed086593f01 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Tue, 18 Aug 2020 16:44:59 -0700 Subject: [PATCH 1/2] Update to go1.15 --- go.mod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 0735ab5cb..e611b1382 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module k8s.io/community -go 1.12 +go 1.15 require ( github.com/client9/misspell v0.3.4 From 6d0c920003581bd4c069aaf2d20ce43669f0b187 Mon Sep 17 00:00:00 2001 From: Aaron Crickenberger Date: Tue, 18 Aug 2020 16:47:51 -0700 Subject: [PATCH 2/2] Allow verify-generated-docs to use go modcache I don't think we need to use an entirely separate GOPATH, thus forcing us to re-download modules every time we run `make` This was causing verify-generated-docs to fail locally since go will set its modcache as readonly and thus cause the cleanup "rm -rf" in this script to fail. In go1.14 or later we could use "-modcacherw" to stop making the modcache readonly but that bring me back to.. why do need an entirely separate GOPATH in the first place? --- hack/verify-generated-docs.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/hack/verify-generated-docs.sh b/hack/verify-generated-docs.sh index 81c850272..6f92c230b 100755 --- a/hack/verify-generated-docs.sh +++ b/hack/verify-generated-docs.sh @@ -21,7 +21,6 @@ set -o pipefail CRT_DIR=$(pwd) VERIFY_TEMP=$(mktemp -d 2>/dev/null || mktemp -d -t k8s-community.XXXXXX) WORKING_DIR="${VERIFY_TEMP}/src/testgendocs" -GOPATH="${VERIFY_TEMP}" mkdir -p "${WORKING_DIR}" function cleanup {