kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

contributor-guide: add note about #pr-reviews channel

This commit is contained in:
Nikhita Raghunath 2019-10-16 11:44:13 +05:30
parent aad32861d0
commit de5ad57f8c
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contributors/guide/contributor-cheatsheet/README.md
View File

@ -218,6 +218,8 @@ other forms of work that would be stored within a git repository.
till the `[WIP]` or hold is lifted.
- If you have not had your PR reviewed, do not close and open a new PR with the
same changes. Ping your reviewers in a comment with `@<github username>`.
- If your PR isn't getting enough attention, post a link to the PR in the
`#pr-reviews` channel on Slack to find additional reviewers.
#### Example PR Description

2
contributors/guide/pull-requests.md
View File

@ -172,6 +172,8 @@ things you can do to move the process along:
* If you have fixed all the issues from a review, and you haven't heard back, you should ping the assignee on the comment stream with a "please take another look" (`PTAL`) or similar comment indicating that you are ready for another review.
* If you still don't hear back, post a link to the pull request in the `#pr-reviews` channel on Slack to find additional reviewers.
Read on to learn more about how to get faster reviews by following best practices.
# Best Practices for Faster Reviews