kubernetes
/
community
mirror of https://github.com/kubernetes/community.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change feature label, add approver and reviewer

This commit is contained in:
Brad Hoekstra 2018-11-12 11:08:29 -05:00
parent 74798ecb09
commit e8a7362d56
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
keps/sig-network/0031-20181017-kube-proxy-services-optional.md
View File

@ -6,12 +6,12 @@ authors:
owning-sig: sig-network owning-sig: sig-network
participating-sigs: participating-sigs:
reviewers: reviewers:
- TBD - "@freehan"
approvers: approvers:
- TBD - "@thockin"
editor: "@bradhoekstra" editor: "@bradhoekstra"
creation-date: 2018-10-17 creation-date: 2018-10-17
last-updated: 2018-10-17 last-updated: 2018-11-12
status: provisional status: provisional
see-also: see-also:
replaces: replaces:
@ -73,7 +73,7 @@ In a cluster where a service is only accessed via other applications in the serv
It is important for overall scalability that kube-proxy does not receive data for Service/Endpoints objects that it is not going to affect. This can reduce load on the kube-proxy and the network by never receiving the updates in the first place. It is important for overall scalability that kube-proxy does not receive data for Service/Endpoints objects that it is not going to affect. This can reduce load on the kube-proxy and the network by never receiving the updates in the first place.
The proposal is to make this feature available by annotating the Service object with this label: `kube-proxy.kubernetes.io/disabled=true`. The associated Endpoints object will automatically inherit that label from the Service object as well. The proposal is to make this feature available by annotating the Service object with this label: `service.kubernetes.io/alternative-service-proxy`. If this label key is set, with any value, the associated Endpoints object will automatically inherit that label from the Service object as well.
When this label is set, kube-proxy will behave as if that service does not exist. None of the functionality that kube-proxy provides will be available for that service. When this label is set, kube-proxy will behave as if that service does not exist. None of the functionality that kube-proxy provides will be available for that service.
@ -97,7 +97,7 @@ The new design will simply add a LabelSelector filter to the shared informer fac
- informerFactory := informers.NewSharedInformerFactory(s.Client, s.ConfigSyncPeriod) - informerFactory := informers.NewSharedInformerFactory(s.Client, s.ConfigSyncPeriod)
+ informerFactory := informers.NewSharedInformerFactoryWithOptions(s.Client, s.ConfigSyncPeriod, + informerFactory := informers.NewSharedInformerFactoryWithOptions(s.Client, s.ConfigSyncPeriod,
+ informers.WithTweakListOptions(func(options *v1meta.ListOptions) { + informers.WithTweakListOptions(func(options *v1meta.ListOptions) {
+ options.LabelSelector = "kube-proxy.kubernetes.io/disabled!=true" + options.LabelSelector = "!service.kubernetes.io/alternative-service-proxy"
+ })) + }))
``` ```
@ -121,4 +121,4 @@ N/A
## Implementation History ## Implementation History
- 2018-10-17 - This KEP is created - 2018-10-17 - This KEP is created
- 2018-10-28 - KEP updated - 2018-11-12 - KEP updated, including approver/reviewer