Commit Graph

46 Commits

Author SHA1 Message Date
Elana Hashman f8148d406c
Note when PUT can create items
See https://github.com/kubernetes/community/issues/6041#issuecomment-1021176213
2022-01-25 11:44:36 -08:00
Tim Hockin b20f6135ee
Loosen the meaning of status in API conventions (#5842)
* Loosen the meaning of status in API conventions

As per KEP https://github.com/kubernetes/enhancements/issues/2527 -
remove the "from observation" guidance and add some discussion of when
to use status fields vs. additional types for allocated resources.

* Backtick spec and status

* Act on feedback
2022-01-10 14:42:25 -08:00
Kubernetes Prow Robot f058d9c79c
Merge pull request #5723 from Jefftree/default
Add default tag to api conventions
2022-01-10 10:33:12 -08:00
Chris Negus 4f95b92105
Add note to api conventions about kind: List (#5903)
* Add note to api conventions about kind: List

* Wording change

* Fixed small typo
2021-10-12 11:32:33 -07:00
Kubernetes Prow Robot 91bc44bf75
Merge pull request #5973 from robscott/kind-vs-resource-refs
Clarifying API Conventions regarding Kind and Resource in object refs
2021-09-14 06:27:09 -07:00
Jefftree 3a97f34b4b Add default tag to api conventions 2021-09-13 10:58:32 -07:00
Khaled (Kal) Henidak 99780a63a6 add auto resource release 2021-09-07 18:40:57 +00:00
Rob Scott 83877032b5
Clarifying API Conventions regarding Kind and Resource in object refs 2021-09-01 15:22:29 -07:00
Kubernetes Prow Robot a843caa9b1
Merge pull request #5832 from toumorokoshi/feature/consolidate-object-reference-guidance
consolidate object ref guidance in api conventions
2021-07-09 10:54:53 -07:00
Yusuke Tsutsumi 00d73216d3 consolidate object ref guidance in api conventions
API conventions had two semi-duplicated sections for
object references, with slightly different guidance.

Consolidating guidance to point to the most recent
guidance.

Clarifying the naming recommendations for naming of lists
of object references, as the guidance was not explicit.
2021-06-18 13:46:40 -07:00
Yusuke Tsutsumi 744e270f33 Apply suggestions from code review
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
2021-06-03 22:44:36 -07:00
Yusuke Tsutsumi 1df12ac90f Adding object references security considerations
Clarifying practices around object references that help
prevent against privilege escalation.
2021-06-03 22:44:36 -07:00
Yusuke Tsutsumi ac7999cb51 Addressing comments
including blurb recommending using multi resource object references
if there is a chance it will be used that way.
2021-05-25 22:32:35 -07:00
Yusuke Tsutsumi bda0f5062e Addressing feeedback
- new section around resources with different versions
- called out edge cases around resource not found
- removed very old todo
2021-05-24 21:51:07 -07:00
Yusuke Tsutsumi 9b694b1b79 Update contributors/devel/sig-architecture/api-conventions.md
Co-authored-by: Daniel Smith <dbsmith@google.com>
2021-05-24 21:51:07 -07:00
Yusuke Tsutsumi fed5c1e6a6 Addressing feedback
- switching fieldpath syntax to reference best practices already in the
spec
- clarifying naming of the object reference field
- fixing a poor example with a kind used where a resource value should
have been.
2021-05-24 21:51:07 -07:00
Yusuke Tsutsumi e5fb87eafa addressing comments
- switched from kind to resource.
- extended examples to four kinds of object references.
- clarified use of JSON Pointer to determine the path to the field.
2021-05-24 21:51:07 -07:00
Yusuke Tsutsumi b1f8f5975c clarifying schema for multi-kind object references
There are a few types of patterns for multi-kind object references
that are currently included in the Kubernetes core resources
(EnvVarSource, ObjectReference).

Adding a section to clarify the preferred pattern for future
resources.
2021-05-24 21:51:07 -07:00
Kubernetes Prow Robot bffe980b66
Merge pull request #5470 from ccouzens/patch-1
API conventions: escape back-quotes when visible
2021-05-10 04:24:51 -07:00
Antoine Pelisse 27e1a81029 Include documentation for listTypes in api conventions 2021-04-05 15:42:41 -07:00
David Eads 86550d6f9b add guidance about avoiding cross namespace references from namespace resources 2021-02-22 15:50:08 -05:00
Chris Couzens 7af4f21daf
API conventions: escape back-quotes when visible
> When referencing another field name, indicate the name in back-quotes. Example: "must be greater than `request`". 

In this sentence, we're meant to see "request" surrounded by back-quotes.

In markdown, backticks (back-quotes) are used to create a code section, and thus aren't shown. By escaping them, they are shown to the user.
2021-02-05 17:28:04 +00:00
Ashish Billore ec191fa473
Minor corrections to the api conventions.
Fixed the API Group convention for readability.
2021-01-10 21:45:50 +09:00
Kubernetes Prow Robot 22e4475215
Merge pull request #5371 from bjhaid/master
Add an entry for `DELETE` on a collection of resources.
2021-01-04 11:41:56 -08:00
bjhaid 2199f730a5 Add an entry for `DELETE` on a collection of resources.
This adds an entry that matches the `GET` on a list of resources.
2020-12-17 14:03:18 -06:00
Paul Weil 05334d450a Correct list api examples and add link to field selector documentation 2020-12-08 13:30:48 -05:00
Clayton Coleman c2a0c7613b
api-conventions: Typo in initials 2020-11-11 14:55:01 -05:00
Clayton Coleman fb6963ada1
api-conventions: Clarify that constant rules apply to flags and config
Also clarify the use of proper names and acronyms within constants with
examples from existing use cases.
2020-11-11 13:14:16 -05:00
Kubernetes Prow Robot 04531ba1ae
Merge pull request #4521 from evankanderson/unconventional
Update Condition guidance
2020-09-24 09:42:05 -07:00
Evan Anderson 0a9d1ebe84 Adjust with suggested language from lavalamp 2020-09-23 22:16:45 -07:00
Evan Anderson dd082f4d2c Add guidance on conditions for long-running reconciliations 2020-09-17 13:51:49 -07:00
Evan Anderson 305d8d8ac0 Fix typo 2020-07-03 11:18:37 -07:00
divya-mohan0209 c9ae4756d5 Updated content under Naming Conventions in api-conventiones.md 2020-06-26 16:30:28 +00:00
Evan Anderson 5f972cff41 Updated with general consensus around resource naming, removed positive-polarity preference 2020-06-25 23:48:12 -07:00
divya-mohan0209 19b6ff012e
Updated api-conventions.md
Modified the first two bullet points under Naming conventions
2020-05-13 18:57:29 +05:30
Evan Anderson 49d3a5aad7 Clarify language thanks to liggitt 2020-04-17 15:16:22 -07:00
Evan Anderson 5cab966cc5 Drop positive-polarity exception for Ready 2020-03-27 14:41:41 -07:00
Evan Anderson 3a2c17b495 Update Condition guidance 2020-02-14 14:46:56 -08:00
Michael Taufen 0f8ce103ad
Remove last-updated date line from api-conventions.md
Rationale: The line hasn't been updated since 2017, even though changes were still being made to the doc. We can already see the last-updated date from the git history, and if we just update it now folks will probably continue forgetting to do so in the future.
2019-11-25 13:52:07 -08:00
Eric Tune a2cdce51a0 Document version string pattern
Document that the version portion of an apiVersion should be a DNS_LABEL.
This is required for CRDs, as encoded here:
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/validation/validation.go#L176-L178
It seems like an eminently reasonable convention to have for built-in and aggregated APIs too.
2019-07-30 08:49:53 -07:00
Jay Pipes 0a79b6dc1e Grammar and Markdown fixes for api-conventions
When going through the api-conventions markdown doc online, I noticed a
couple small grammar and Markdown formatting issues. This patch fixes
those up.
2019-05-31 17:24:31 -04:00
Wojciech Sciesinski 95bb2fbd88 Fix link in api-conventions.md (#3739)
* Correct the link target

* Make the link description more precise

* Correct the link target - once again.

Co-Authored-By: Christoph Blecker <admin@toph.ca>
2019-05-27 10:59:50 -07:00
Paul Morie f2ea353488 Remove inconsistent use of bool as example 2019-05-22 10:07:45 -04:00
Lance Bragstad 702d10d7a4 Update links in api conventions document
As I was reading through api-conventions.md, I noticed a couple of
broken links. This commit updates those links to resolve to their
previously linked content.
2019-03-29 19:03:26 +00:00
Ivan Akulov 745d689910
Fix the link to the Strategic Merge Patch doc 2019-03-06 10:59:17 +03:00
eduartua 06207d2363 Created tombstone files for files moved to /devel/sig-architecture - URLs updated in k/community 2019-01-24 16:48:03 -06:00