Merge pull request #476 from thockin/v4-double-register-hook-metric

Don't double-register the hook metric (v4)
This commit is contained in:
Kubernetes Prow Robot 2022-01-23 01:17:56 -08:00 committed by GitHub
commit 10fd8e662b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions

View File

@ -34,6 +34,10 @@ var (
}, []string{"name", "status"})
)
func init() {
prometheus.MustRegister(hookRunCount)
}
// Describes what a Hook needs to implement, run by HookRunner
type Hook interface {
// Describes hook
@ -115,7 +119,6 @@ func (r *HookRunner) Send(hash string) {
// Run waits for trigger events from the channel, and run hook when triggered
func (r *HookRunner) Run(ctx context.Context) {
var lastHash string
prometheus.MustRegister(hookRunCount)
// Wait for trigger from hookData.Send
for range r.data.events() {