kubernetes
/
git-sync
mirror of https://github.com/kubernetes/git-sync.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #408 from briantkennedy/rel 

Improve error message for askpass.
This commit is contained in:
Kubernetes Prow Robot 2021-06-15 14:13:43 -07:00 committed by GitHub
parent 2abd898038 edb3f08ec0
commit 921bd812d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/git-sync/main.go
View File

@ -1136,11 +1136,17 @@ func callGitAskPassURL(ctx context.Context, url string) error {
if err != nil { if err != nil {
return fmt.Errorf("can't access auth URL: %w", err) return fmt.Errorf("can't access auth URL: %w", err)
} }
defer func() {
_ = resp.Body.Close()
}()
if resp.StatusCode != 200 { if resp.StatusCode != 200 {
return fmt.Errorf("auth URL returned status %d", resp.StatusCode) errMessage, err := ioutil.ReadAll(resp.Body)
if err != nil {
return fmt.Errorf("auth URL returned status %d, failed to read body: %w", resp.StatusCode, err)
}
return fmt.Errorf("auth URL returned status %d, body: %q", resp.StatusCode, string(errMessage))
} }
authData, err := ioutil.ReadAll(resp.Body) authData, err := ioutil.ReadAll(resp.Body)
resp.Body.Close()
if err != nil { if err != nil {
return fmt.Errorf("can't read auth response: %w", err) return fmt.Errorf("can't read auth response: %w", err)
} }