45bba183ca
Add --git-config flag
...
This allows arbitrary git configs to be passed in. For example:
`git config --global http.postBuffer 1048576000`
`git config --global http.sslCAInfo /path/to/cert/file`
`git config --global http.sslVerify false`
This flag takes a comma-separated list of `key:val` pairs. The key part
is passed to `git config` and must be a valid gitconfig section header
and variable name. The val part can be either a quoted or unquoted
value. For all values the following escape sequences are supported:
* `\n` => [newline]
* `\t` => [tab]
* `\"` => `"`
* `\,` => `,`
* `\\` => `\`
Within unquoted values, commas MUST be escaped. Within quoted values,
commas MAY be escaped, but are not required to be. Any other escape
sequence is an error.
Example:
`--git-config=foo.one:val1,foo.two:"quoted val",foo.three:12345`
This commit exposed a bug in runCommand() which modified its args when
they had an embedded space.
2021-03-10 19:07:05 -08:00
ffba2eb119
Allow octal and hex values for int flags
...
This is specifcally relevant to --change-permissions.
2021-01-06 13:49:02 -08:00
26cd942b2a
change to a command name with no args
2020-10-02 19:29:03 +09:00
e1c4717de6
add an option to run the command when the repository is updated
2020-10-02 19:28:25 +09:00
44e94a16b0
Fix webhook regression: allow -1 to ignore status
2020-09-25 11:17:56 -07:00
66320a6b92
Merge pull request #243 from killuazhu/kyle-relax-wait
...
Relax wait between sync
2020-09-25 10:30:26 -07:00
4225d000e0
Clean up askpass function to take url as arg
2020-09-07 17:16:56 -07:00
ed57c29d83
Merge pull request #275 from thockin/7-askpass-metric
...
Add metric for askpass, noop sync != success
2020-09-07 17:11:42 -07:00
9cef5f8ced
Improve flag input checking and errors
2020-09-05 10:30:25 -07:00
f67c13654e
Merge pull request #277 from thockin/9-better-logs
...
Better logs and errors
2020-09-05 10:27:40 -07:00
9c56b25591
Merge pull request #276 from thockin/8-use-filepath
...
use filepath.Join, drop dep on path
2020-09-05 10:25:41 -07:00
04c85ee1dc
Add metric for askpass, noop sync != success
2020-09-05 10:24:08 -07:00
37f74f46fe
Merge pull request #274 from thockin/6-better-run-logs
...
Improve logs when running a command
2020-09-05 10:21:41 -07:00
7d63180e78
Merge pull request #272 from thockin/4-move-setFlagDefaults
...
Move setFlagDefaults closer to flag code
2020-09-05 10:17:41 -07:00
e43fb2513e
Better logs and errors
2020-09-04 20:14:51 -07:00
07b1ab7572
use filepth.Join, drop dep on path
2020-09-04 20:13:22 -07:00
5ac2975ec4
Improve logs when running a command
2020-09-04 20:11:34 -07:00
af755fbe99
Move setFlagDefaults closer to flag code
2020-09-04 20:07:47 -07:00
89aad82a31
Minor tweaks to submodules strings & consts
...
Rename consts internally and shorten help string a bit.
2020-09-04 20:06:44 -07:00
366e08ff40
Trivial comment change
2020-09-04 20:03:04 -07:00
dcf169c10a
add option to NOT recursively clone submodules ( #246 )
...
* add option to NOT recursively clone submodules
* Add "shallow" and "off" modes to submodule clone
* update readme to reflect new flag
* wording and such feedback
2020-07-30 21:29:07 -07:00
f44e140358
fix typo
...
fix typo
2020-06-30 16:21:33 +08:00
1546e3415f
Reduce wait time
2020-04-24 17:32:32 -04:00
c1d4d77216
Relax wait between sync
2020-04-24 15:21:09 -04:00
82cd91958b
Split stdout/stderr in runCommand()
...
Sometimes git emits things on stderr that are not errors but not part of
the programmatic output either. Don't combine the output.
2020-03-20 13:44:33 -07:00
95a1690e6f
Fix 2 bugs in pid1
...
1) Was calling Wait() on the child process, but also calling Wait4,
which would race, causing an occasional error or panic.
2) In testing (1), I observed occasional hangs. Tracing it down to a
SIGWINCH, which masked a SIGCHLD, causing it to hang. Both seem fixed.
Added a manual test script.
2020-03-20 13:44:27 -07:00
4a75452461
avoid accessing Request in webhook.go until possible error due to invalid url has been handled
2020-03-16 19:49:59 +00:00
ef8f5cf703
Bump to debian-base 2.0.0 (buster)
...
This changed `git fetch` to require a `-f` the way we use it.
Also fix a flaky test case for SSH.
2020-01-31 09:20:54 -08:00
72deefcec3
Make health check meaningful
2020-01-09 17:20:11 -08:00
5154ace66d
Add --add-user to write UID/GID to passwd
2020-01-03 16:16:15 -08:00
b0bdc02e8b
manually merge https://github.com/kubernetes/git-sync/pull/217
2019-12-18 20:05:51 -08:00
31f276dd58
fix comments
2019-12-18 10:59:20 -08:00
6c6c354c72
update docs from auth-url to askpass-url
2019-12-17 11:02:03 -08:00
67a0788aa2
Rename to GIT_ASKPASS_URL and also update related examples.
2019-12-17 10:48:20 -08:00
9cae624f8c
Add a new authentiate method GIT_SYNC_AUTH_URL.
...
It specifies a HTTP URL which will return username&password which will
be used to authenticate access to the git repo.
This is mainly used for git repo accecpt dynamic password (for example
oauth bare token). Because the dynamic password might expire very soon,
so it's added to the main syncRepo loop.
Typical usage case is work with a sidecar called gce-node-auth on GKE,
it uses the GCE service account's oauth token as password to access
Cloud Source Repo.
Please see the repo below for how it worked.
https://github.com/cydu-cloud/gce-node-auth/blob/master/git-sync-with-gce-node-auth.yaml
2019-12-16 23:45:37 -08:00
a2a8f72733
Merge pull request #211 from thockin/log-cleanups
...
Log before running commands, not after
2019-11-27 23:33:03 -08:00
eac27f505e
Log before actions
2019-11-26 13:45:18 -08:00
fc700779be
Log chmod operation
2019-11-26 13:45:18 -08:00
e97eff010f
trivial comments
2019-11-26 13:42:15 -08:00
287a0e5464
var renames for readability
2019-11-26 13:42:15 -08:00
415303f900
Rename for clarity
2019-11-26 13:42:15 -08:00
5d7622e6ec
Merge pull request #208 from thockin/code-move-cleanups
...
Code move cleanups
2019-11-26 01:05:10 -08:00
cbad455c2b
Merge pull request #205 from thockin/git-cat-file
...
Make revIsHash a bit safer
2019-11-23 02:41:49 -08:00
74d3e9daab
move code for readability
2019-11-21 21:57:53 -08:00
d980b6d9d6
Move prune logic for cohesion
2019-11-21 21:57:53 -08:00
dc5bdcb461
Better flag help strings
2019-11-21 21:47:15 -08:00
1b295ad217
Make revIsHash a bit safer
2019-11-21 08:55:30 -08:00
f433b067ca
Rename snake_case variable
2019-11-21 08:48:36 -08:00
5daf3a42f7
Clean up webhook a bit
...
Return hash so we don't need to recalculate.
Rename some funcs.
2019-11-17 13:22:38 -08:00
7353b157b2
Merge pull request #193 from peick/http-header-webhook
...
Sent git hash and branch in the HTTP header of the webhook.
2019-10-29 09:16:46 -07:00
012d0bfbf0
Merge pull request #194 from thockin/fix-pid1
...
Handle running as PID 1
2019-10-28 15:52:43 -07:00
5cb2198689
Remove unnecessary comment.
2019-10-28 21:58:44 +01:00
440eac730e
Make hash value updates and reads atomic using mutex.
2019-10-28 21:57:03 +01:00
26f21906be
Merge pull request #197 from hypnoglow/fix-nits
...
Fix minor issues from linters
2019-10-28 13:26:44 -07:00
4bb587e083
Merge pull request #190 from hypnoglow/switch-to-runcommand
...
Replace exec.Command with runCommand
2019-10-28 13:24:43 -07:00
bff7e7bf43
Replace exec.Command with runCommand
2019-10-28 22:16:56 +03:00
7a3c0679d5
Fix minor issues from linters
2019-10-28 22:05:39 +03:00
2a42fba009
Handle running as pid 1
...
This detects when it is running as pid 1, and becomes an init process.
Specifically this means handling SIGCHLD and reaping processes
(otherwise they become zombies) and forwarding signals to "real"
process.
We fork and re-exec ourselves so that we only get *this* SIGCHLD for
orphaned processes (re-parented to 1) and not the real events from
running things like git or ssh.
2019-10-27 09:45:27 -07:00
c3d026bf2b
Cleanup test.
2019-10-27 14:47:18 +01:00
f0ec409582
Populate last hash value in case webhook is slower than the main loop.
2019-10-27 14:33:40 +01:00
e214aeb4d6
Rename http header "Git-Sync-Hash" into "Gitsync-Hash".
2019-10-26 13:34:39 +02:00
1eb223e2cc
Do not send branch information as http header.
2019-10-26 13:34:16 +02:00
9ecc67fb3a
Sent git hash and branch in the HTTP header of the webhook.
2019-10-25 10:42:37 +02:00
94818756af
🔧 ☔ add depth flag support and cover with tests
2019-10-21 10:40:51 +02:00
d263429c6d
🎨 add todo comment for --depth flag support
2019-10-18 17:50:04 +02:00
41c8572ad6
☔ add tests
2019-10-11 17:58:47 +02:00
3f06a3ba4b
:spakrles: add git submodules support
2019-10-02 16:41:28 +02:00
bbf6d60f36
git-sync: removes special exit on first error
...
Old code used to exit at any error seen on first sync attempt. This
didn't prove useful in practice, so removing that special case.
This may make git-sync slower to recover after user fixes a
non-retryable error, as now flMaxSyncFailures are needed before the pod
fails. It may make sense in practice.
Fixes #161 , in a different way than is proposed in PR #162 .
2019-04-02 10:06:00 -07:00
4493070350
Add --version flag
2019-03-25 08:54:44 -07:00
831eae8f9f
Use official logr rather than thockin
2019-03-25 08:54:44 -07:00
51f19b81c9
Fix SSH
...
* Create a git-sync user to run as, with an entry in /etc/passwd and
writable homedir
* Remove our own validation of key perms - let SSH do that.
* Update docs,
2019-02-07 16:32:01 -08:00
abf5f0748d
Merge branch 'master' into metrics
2019-01-23 08:18:21 -08:00
6cfa3e1690
Add pprof endpoint
...
This requires moving to a non-default ServeMux so we can control whether
pprof is enabled or not
2019-01-22 17:26:27 -08:00
73a0e50ee1
Add dumb liveliness endpoint
...
This currently returns 200 always. In the future we can add options for
controling what constitues "liveliness"
2019-01-22 17:26:27 -08:00
0beb2decf4
Change HTTP flags
...
This enables the HTTP endpoint by default using ":8080". In addition
this adds a flag for disabling the metrics endpoint
2019-01-22 17:26:27 -08:00
e32712b301
Add basic prometheus metrics
2019-01-22 17:26:27 -08:00
4df44b1fcf
Add http handler option
2019-01-22 17:26:27 -08:00
f1a1a1b61e
Use depth option when doing fetches
...
Previously the `depth` flag was only used for the initial clone-- so
although you might start with a depth=10 as more commits show up you are
always >10. With this diff we enforce that depth on each fetch, this way
old-commits can get GCd off to reduce the size of the local checkout
required.
2019-01-22 16:44:16 -08:00
87503c6dce
Clarify webhook behavior in docs/README
2019-01-22 14:12:49 -08:00
edaa75b8a5
Remove empty comment line
2019-01-22 14:12:49 -08:00
ad41260327
Clarify success-status config/option
2019-01-22 14:12:49 -08:00
54ec971ba0
Remove "duration" from flag/env/var names
2019-01-22 14:12:49 -08:00
6e0bd948ec
Add option to control backoff for failed webhook calls
2019-01-22 14:12:49 -08:00
fdc9b49de2
Reduce to a single webhook call
2019-01-22 14:12:49 -08:00
96714ebed2
Remove global trigger channel
...
Instead change syncRepo to return a boolean which is whether a change
occured.
2019-01-22 14:12:49 -08:00
39ca0a2ca0
Fix error log to print out actual status codes
2019-01-22 14:12:49 -08:00
18f68d3ab6
Move timeout into the json arg for webhook
2019-01-22 14:12:49 -08:00
a45699efb1
goimports
2019-01-22 14:12:49 -08:00
160d68f29c
removed unecessary logs
2019-01-22 14:12:49 -08:00
6b8aac0b83
modularized and documented
2019-01-22 14:12:49 -08:00
e437d8e9a3
adding changes from previous PR, updated README
2019-01-22 14:12:49 -08:00
01f007a753
updated verbosity settings for POST request log
2019-01-22 14:12:49 -08:00
f8f555d73a
updated post request code
2019-01-22 14:12:49 -08:00
0eac8fc5cf
added some logs and moved where the post request is made
2019-01-22 14:12:49 -08:00
7f64d79bbe
Updated main to add the env var and send a post request
2019-01-22 14:12:49 -08:00
b9c0ed3f5d
Update env vars based on comments
2019-01-22 13:41:45 -08:00
088065e494
Normalize flag names to include `-file`
2019-01-22 13:41:45 -08:00
933bbdfc1f
Add flag for ssh known hosts file
2019-01-22 13:41:45 -08:00
c4c68e2620
Move SSH key path to a flag
2019-01-22 13:41:45 -08:00
5573584fc6
Only allow -1 as "unlimited failures"
2019-01-18 09:08:50 -08:00
Tim Hockin
unknowingknow
Kubernetes Prow Robot
alix.cook11
windayski
Kyle Zhu
Reuben Thomas-Davis
Chuanying Du
Michael Peick
Igor Zibarev
Michal Lula
Filip Filmar
Thomas Jackson
Zac
Zac