1fdc98e3b0
Document that short SHAs dont work
2023-11-12 16:20:26 -06:00
a5cec7a036
Log less verbose flags in less verbose mode
2023-11-01 13:26:34 -07:00
2639ff475d
e2e: use global 'user.email' config
2023-10-14 15:55:00 -07:00
83bd660494
Recover if wrong worktree HEAD
2023-10-14 15:55:00 -07:00
befdbfff31
Remove errant use of --period with --one-time
2023-10-14 11:29:18 -07:00
1a5daeaf43
Add e2e case for missing worktree after crash
2023-10-14 11:29:12 -07:00
b69d0f3bac
Logging: log syncCount and be less scary
2023-10-14 11:29:03 -07:00
8fa652dafa
Break up main.go
...
Add new files for abspath, credential, and env functions.
2023-10-13 13:27:52 -07:00
ff51ca92dc
fix: infinite bad loop caused by unexpected worktree directory removal
2023-10-13 13:20:54 -07:00
6426efe346
If --repo is not a URL, it's not an error
2023-10-13 12:35:13 -07:00
fc5e065878
Only redact the URL password if it was provided
2023-10-13 12:35:13 -07:00
bb1dc0b7a5
Update v3-v4 doc on ssh
2023-10-12 12:50:27 -07:00
162e543e05
Add --credential flag to spec multiple user/pass
...
* New flag is a JSON-encoded struct.
* Add test case for multiple HTTP passwd.
2023-10-08 14:46:41 -07:00
7da482e001
Add v4 note about change-permissions and exechook
...
This is sort of a regression in v4 vs, v3, but ths use case is pretty
niche, I think.
2023-10-01 15:31:43 -07:00
4ccf0633fb
Deprecate --ssh - it's not really needed
...
As long as a repo uses SSH transport (user@host:path or ssh://...), SSH
is active. This is true for the main repo or submodules.
2023-09-27 13:32:15 -07:00
32c3a0c2a7
e2e: Add assert_fail and simplify fail cases
2023-09-21 12:48:59 -07:00
627fe23a9a
e2e: Always pre-write FUNCNAME into repo/file
...
This removes a few LOC from many cases
2023-09-21 09:09:58 -07:00
66e0ba3562
e2e: merge SSH fail and success cases
2023-09-20 14:30:28 -07:00
a8d5675e1d
Add e2e for password-file
2023-09-20 12:46:13 -07:00
d4244a3424
e2e: reorder some flags for clarity
2023-09-20 09:31:15 -07:00
96b8e8a4fc
Remove redundant username/password auth test
...
The HTTP test covers this without needing a hacky git command.
2023-09-20 09:31:15 -07:00
8310ee9ee8
Auth tests really only need to sync once
...
Except for URL tests which prove resilience to failure.
2023-09-20 09:31:15 -07:00
86725cb85e
Reorder tests to put auth together
...
No other changes
2023-09-20 09:31:15 -07:00
9bf6d7778d
Set core.askPass config for better auth-fail error
...
Instead of "No such device or address", which is pretty obtuse, we now
get "Authentication failed".
2023-09-20 09:31:02 -07:00
af6b96ab74
Add e2e for username/password over HTTP
2023-09-19 14:57:41 -07:00
dbd0567882
Use correct keys on env parsing of alt names
...
These names are back-compat
2023-09-19 14:18:30 -07:00
11b8d151d0
Clean up submodule cases to be a bit more readable
2023-09-19 13:40:40 -07:00
55f71d55ed
Add a test case for submodules with diff SSH keys
2023-09-19 13:31:19 -07:00
29b291e9c2
Add support for multiple SSH keys
...
The --ssh-key-file flag can be specified more than once and the
GITSYNC_SSH_KEY_FILE env var will be parsed like PATH.
Also adds e2e coverage for wrong-key and for multiple keys.
2023-09-19 13:31:19 -07:00
50de3aaeab
Dump logs when e2e fails in CI
2023-09-19 13:20:09 -07:00
310cbaea37
Add $GITSYNC_VERBOSE to set verbosity via env
2023-09-15 08:28:08 -07:00
1cab59e22e
Merge pull request #800 from kubernetes/dependabot/github_actions/actions/checkout-4
...
Bump actions/checkout from 3 to 4
2023-09-08 12:24:30 -07:00
a6c813b84d
Bump actions/checkout from 3 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-04 13:18:24 +00:00
e0016481f7
Merge pull request #798 from phil-park/master
...
fix: Fix backward compatibility of environment variables with bool type
2023-08-31 16:06:30 -07:00
8bb3467a24
fix: Fix backward compatibility of environment variables with bool type
...
Signed-off-by: Jiwon Park <bakjeeone@hotmail.com>
2023-08-31 07:39:54 +09:00
5e5035d029
Merge pull request #794 from thockin/master
...
Add /tmp to staging
2023-07-31 12:34:39 -07:00
7a72116ccc
Add /tmp to staging
2023-07-31 08:36:34 -07:00
f602004cd4
lint: Add golangci based on kubernetes/kubernetes.
...
Adapted the "strict" settings, but removed a few exclusions that
aren't relevant here (e.g. zz_generated), and removed the custom
logcheck linter (as we aren't currently using structured logging).
2023-07-29 16:43:25 -07:00
8656ab6183
lint: Add linters to makefile / github CI
...
Not yet ready to make gating, but we can watch the progress.
2023-07-29 16:43:25 -07:00
d86e70f744
Merge pull request #792 from justinsb/fix_remaining_lint_issues
...
lint: fix remaining lint issues.
2023-07-29 16:34:00 -07:00
bb22144d4f
lint: fix remaining lint issues.
...
These fix the issues identified by the k/k inspired linter
configuration that we will be adding:
```
pkg/pid1/pid1.go:72:14: ST1005: error strings should not end with punctuation or newlines (stylecheck)
return 0, fmt.Errorf("unhandled exit status: 0x%x\n", status)
^
pkg/pid1/pid1.go:86:21: ST1005: error strings should not end with punctuation or newlines (stylecheck)
return false, 0, fmt.Errorf("wait4(): %w\n", err)
^
main.go:480:34: Error return value of `pflag.CommandLine.MarkDeprecated` is not checked (errcheck)
pflag.CommandLine.MarkDeprecated("branch", "use --ref instead")
^
main.go:483:34: Error return value of `pflag.CommandLine.MarkDeprecated` is not checked (errcheck)
pflag.CommandLine.MarkDeprecated("change-permissions", "use --group-write instead")
^
main.go:486:34: Error return value of `pflag.CommandLine.MarkDeprecated` is not checked (errcheck)
pflag.CommandLine.MarkDeprecated("dest", "use --link instead")
^
main.go:1897:16: Error return value of `io.WriteString` is not checked (errcheck)
io.WriteString(h, s)
^
main.go:555:2: ifElseChain: rewrite if-else to switch statement (gocritic)
if *flDeprecatedBranch != "" && (*flDeprecatedRev == "" || *flDeprecatedRev == "HEAD") {
^
```
2023-07-29 16:41:23 -04:00
41b71f5ce4
Merge pull request #788 from thockin/fix_git_option_parsing_goroutine_leak
...
Fix goroutine leak in git option parsing
2023-07-29 13:06:00 -07:00
9163f8fac2
Merge pull request #791 from thockin/rename_ghaction_build_job
...
Rename github build workflow
2023-07-29 13:03:59 -07:00
ee35dad8bc
Merge pull request #789 from thockin/percent_w_for_errors
...
Replace all error %v with %w
2023-07-29 13:02:00 -07:00
0971564436
Merge pull request #790 from thockin/add_dependabot_for_gh_actions
...
Add dependabot for github actions
2023-07-29 13:00:00 -07:00
251fd7b0b7
Rename github build workflow
2023-07-29 10:40:29 -07:00
7e8adfe87f
Add dependabot for github actions
2023-07-29 10:35:07 -07:00
71a5542f75
Merge pull request #786 from justinsb/enable_github_actions
...
Enable github actions for CI
2023-07-29 10:28:00 -07:00
a9b3f8965c
Replace all error %v with %w
2023-07-29 10:21:39 -07:00
d4f0c07bf1
Fix goroutine leak in git option parsing
2023-07-29 10:18:02 -07:00
Tim Hockin
Aleksandar Markovski
Kubernetes Prow Robot
dependabot[bot]
Jiwon Park
justinsb