Continue attemps to dump artifacts in `toolbox dump`

This way if one of the earlier methods fails, we can still get some artifacts from the later methods
This commit is contained in:
Peter Rifel 2024-02-28 16:42:18 +01:00
parent c5551a005d
commit 045bd4932b
No known key found for this signature in database
1 changed files with 3 additions and 3 deletions

View File

@ -232,7 +232,7 @@ func RunToolboxDump(ctx context.Context, f commandutils.Factory, out io.Writer,
} }
if err := dumper.DumpAllNodes(ctx, nodes, options.MaxNodes, additionalIPs, additionalPrivateIPs); err != nil { if err := dumper.DumpAllNodes(ctx, nodes, options.MaxNodes, additionalIPs, additionalPrivateIPs); err != nil {
return fmt.Errorf("error dumping nodes: %v", err) klog.Warningf("error dumping nodes: %v", err)
} }
if kubeConfig != nil && options.K8sResources { if kubeConfig != nil && options.K8sResources {
@ -241,7 +241,7 @@ func RunToolboxDump(ctx context.Context, f commandutils.Factory, out io.Writer,
return fmt.Errorf("error creating resource dumper: %w", err) return fmt.Errorf("error creating resource dumper: %w", err)
} }
if err := dumper.DumpResources(ctx); err != nil { if err := dumper.DumpResources(ctx); err != nil {
return fmt.Errorf("error dumping resources: %w", err) klog.Warningf("error dumping resources: %v", err)
} }
logDumper, err := dump.NewPodLogDumper(kubeConfig, options.Dir) logDumper, err := dump.NewPodLogDumper(kubeConfig, options.Dir)
@ -249,7 +249,7 @@ func RunToolboxDump(ctx context.Context, f commandutils.Factory, out io.Writer,
return fmt.Errorf("error creating pod log dumper: %w", err) return fmt.Errorf("error creating pod log dumper: %w", err)
} }
if err := logDumper.DumpLogs(ctx); err != nil { if err := logDumper.DumpLogs(ctx); err != nil {
return fmt.Errorf("error dumping pod logs: %w", err) klog.Warningf("error dumping pod logs: %v", err)
} }
} }
} }