kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10296 from hakman/remove-legacy-elb-name 

Remove support for using legacy ELB name
This commit is contained in:
Kubernetes Prow Robot 2020-11-22 11:31:42 -08:00 committed by GitHub
parent 064e39299b ffe0af8629
commit 16e922141a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/model/context.go
View File

@ -44,8 +44,6 @@ const (
clusterAutoscalerNodeTemplateTaint = "k8s.io/cluster-autoscaler/node-template/taint/"
)
var UseLegacyELBName = featureflag.New("UseLegacyELBName", featureflag.Bool(false))
// KopsModelContext is the kops model
type KopsModelContext struct {
iam.IAMModelContext
@ -60,16 +58,6 @@ type KopsModelContext struct {
func (m *KopsModelContext) GetELBName32(prefix string) string {
c := m.Cluster.ObjectMeta.Name
if UseLegacyELBName.Enabled() {
tokens := strings.Split(c, ".")
s := fmt.Sprintf("%s-%s", prefix, tokens[0])
if len(s) > 32 {
s = s[:32]
}
klog.Infof("UseLegacyELBName feature-flag is set; built legacy name %q", s)
return s
}
// The LoadBalancerName is exposed publicly as the DNS name for the load balancer.
// So this will likely become visible in a CNAME record - this is potentially some
// information leakage.