kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5277 from gambol99/misspelling 

Verify Spelling
This commit is contained in:
k8s-ci-robot 2018-06-06 08:57:26 -07:00 committed by GitHub
parent 9973908c7b 67296c2db9
commit 1fe29cf962
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
17 changed files with 31 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Makefile
View File

@ -503,6 +503,15 @@ verify-gofmt:
verify-packages: ${BINDATA_TARGETS}
hack/verify-packages.sh
.PHONY: verify-misspelling
verify-misspelling:
@which misspell 2>/dev/null ; if [ $$? -eq 1 ]; then \
go get -u github.com/client9/misspell/cmd/misspell; \
fi
@find . -type f \( -name "*.go*" -o -name "*.md*" \) -a \( -not -path "./vendor/*" -not -path "./_vendor/*" \) | \
sed -e /README-ES.md/d -e /node_modules/d | \
xargs misspell -error
.PHONY: verify-gendocs
verify-gendocs: ${KOPS}
@TMP_DOCS="$$(mktemp -d)"; \
@ -523,7 +532,7 @@ verify-bazel:
# verify-package has to be after verify-gendoc, because with .gitignore for federation bindata
# it bombs in travis. verify-gendoc generates the bindata file.
.PHONY: ci
ci: govet verify-gofmt verify-boilerplate verify-bazel nodeup examples test | verify-gendocs verify-packages verify-apimachinery
ci: govet verify-gofmt verify-boilerplate verify-bazel verify-misspelling nodeup examples test | verify-gendocs verify-packages verify-apimachinery
echo "Done!"
# --------------------------------------------------

2
cmd/kops/integration_test.go
View File

@ -296,7 +296,7 @@ func runTest(t *testing.T, h *testutils.IntegrationTestHarness, clusterName stri
t.Fatalf("unexpected data files. actual=%q, expected=%q", actualDataFilenames, expectedDataFilenames)
}
// Some tests might provide _some_ tf data files (not necessarilly all that
// Some tests might provide _some_ tf data files (not necessarily all that
// are actually produced), validate that the provided expected data file
// contents match actual data file content
expectedDataPath := path.Join(srcDir, "data")

4
docs/apireference/build/README.md
View File

@ -6,7 +6,7 @@ Static compilation of html from markdown including processing for grouping code
\> bdocs-tab:kubectl Deployment Config to run 3 nginx instances (max rollback set to 10 revisions).
bdocs-tab:tab will be stripped during rendering and utilized to with CSS to show or hide the prefered tab. kubectl indicates the desired tab, since blockquotes have no specific syntax highlighting.
bdocs-tab:tab will be stripped during rendering and utilized to with CSS to show or hide the preferred tab. kubectl indicates the desired tab, since blockquotes have no specific syntax highlighting.
\`\`\`bdocs-tab:kubectl_yaml
apiVersion: extensions/v1beta1
@ -42,7 +42,7 @@ As a NodeJS program, a valid installation of node is required. Once node is inst
```
node --version
```
Next, depedencies need to be installed via npm from the root of the project directory.
Next, dependencies need to be installed via npm from the root of the project directory.
```
npm install
```

2
docs/examples/coreos-kops-tests-multimaster.md
View File

@ -1,6 +1,6 @@
# USING KOPS WITH COREOS - A MULTI-MASTER/MULTI-NODE PRACTICAL EXAMPLE
## WHAT WE WANT TO ACOMPLISH HERE?
## WHAT WE WANT TO ACCOMPLISH HERE?
The exercise described in this document will focus on the following goals:

2
docs/examples/kops-test-route53-subdomain.md
View File

@ -1,6 +1,6 @@
# USING KOPS WITH A ROUTE53 BASED SUBDOMAIN AND SCALING UP THE CLUSTER
## WHAT WE WANT TO ACOMPLISH HERE/
## WHAT WE WANT TO ACCOMPLISH HERE/
The exercise described in this document will focus on the following goals:

2
docs/examples/kops-tests-private-net-bastion-host.md
View File

@ -1,6 +1,6 @@
# USING KOPS WITH PRIVATE NETWORKING AND A BASTION HOST IN A HIGLY-AVAILABLE SETUP
## WHAT WE WANT TO ACOMPLISH HERE?
## WHAT WE WANT TO ACCOMPLISH HERE?
The exercise described in this document will focus on the following goals:

2
docs/releases/1.6.2.md
View File

@ -7,7 +7,7 @@
* Apply cloud-labels to EBS volumes (thanks @pastjean)
* Support empty `--resolv-conf` (thanks @austinmoore-)
* Add --subnet and --role flags to create ig command (thanks @dtan4)
* Improvments to `kops delete` output (thanks @chrislovecnm)
* Improvements to `kops delete` output (thanks @chrislovecnm)
* Match type (public/private) of DNS zones when matching (thanks @justinsb)
* CoreOS command now finds the latest image (thanks @gianrubio)
* Protokube now checks if kubelet is already running before calling systemctl start (thanks @aledbf)

2
docs/releases/1.7-NOTES.md
View File

@ -16,7 +16,7 @@ This document describes changes in the kops 1.7 release (compared to the 1.6 rel
# Required Actions
* Existing Calico users on clusters that were created prior to kops 1.7 are suspectible to IP conflict between Pods and Services due to an overlap of the two IP ranges. Migration to a new Pod CIDR is recommended, and is a manual procedure due to risk of potential downtime during this operation. For the migration procedure, please refer to [this document](../upgrade_from_kops_1.6_to_1.7_calico_cidr_migration.md).
* Existing Calico users on clusters that were created prior to kops 1.7 are susceptible to IP conflict between Pods and Services due to an overlap of the two IP ranges. Migration to a new Pod CIDR is recommended, and is a manual procedure due to risk of potential downtime during this operation. For the migration procedure, please refer to [this document](../upgrade_from_kops_1.6_to_1.7_calico_cidr_migration.md).

4
docs/releases/1.8-NOTES.md
View File

@ -197,7 +197,7 @@ or specify a different network (current using `--vpc` flag)
* Fix README.md fragment links [@poweld](https://github.com/poweld) [#3260](https://github.com/kubernetes/kops/pull/3260)
* Fix heading on 1.7 notes [@justinsb](https://github.com/justinsb) [#3237](https://github.com/kubernetes/kops/pull/3237)
* Add hints to CF integration test [@justinsb](https://github.com/justinsb) [#3139](https://github.com/kubernetes/kops/pull/3139)
* Add documentaion to kube-router section of docs/networking [@murali-reddy](https://github.com/murali-reddy) [#3262](https://github.com/kubernetes/kops/pull/3262)
* Add documentation to kube-router section of docs/networking [@murali-reddy](https://github.com/murali-reddy) [#3262](https://github.com/kubernetes/kops/pull/3262)
* Update images in CI tests [@justinsb](https://github.com/justinsb) [#3264](https://github.com/kubernetes/kops/pull/3264)
* Validate AWS machine type on cluster ig update [@KashifSaadat](https://github.com/KashifSaadat) [#3257](https://github.com/kubernetes/kops/pull/3257)
* Docker Default Ulimits [@gambol99](https://github.com/gambol99) [#3259](https://github.com/kubernetes/kops/pull/3259)
@ -529,7 +529,7 @@ or specify a different network (current using `--vpc` flag)
* Use upsert when applying DNS records [@justinsb](https://github.com/justinsb) [#3859](https://github.com/kubernetes/kops/pull/3859)
* Fix Autoscaling flag on Controller Manager Config [@david92rl](https://github.com/david92rl) [#3872](https://github.com/kubernetes/kops/pull/3872)
* Include encryptionConfig setting within userdata for masters. [@KashifSaadat](https://github.com/KashifSaadat) [#3874](https://github.com/kubernetes/kops/pull/3874)
* Add Exemple for instance group tagging [@sergeohl](https://github.com/sergeohl) [#3879](https://github.com/kubernetes/kops/pull/3879)
* Add Example for instance group tagging [@sergeohl](https://github.com/sergeohl) [#3879](https://github.com/kubernetes/kops/pull/3879)
* README and issue template updates [@chrislovecnm](https://github.com/chrislovecnm) [#3818](https://github.com/kubernetes/kops/pull/3818)
* Kops Template Config Value [@gambol99](https://github.com/gambol99) [#3863](https://github.com/kubernetes/kops/pull/3863)
* Fix spelling [@jonstacks](https://github.com/jonstacks) [#3864](https://github.com/kubernetes/kops/pull/3864)

8
docs/releases/1.9-NOTES.md
View File

@ -309,7 +309,7 @@ None known at this time
* Typo fix "etcd manager"->"etcd-manager" [@AdamDang](https://github.com/AdamDang) [#4628](https://github.com/kubernetes/kops/pull/4628)
* Typo fix "provides"->"provide" [@AdamDang](https://github.com/AdamDang) [#4622](https://github.com/kubernetes/kops/pull/4622)
* Typo instance group ->"InstanceGroup" [@AdamDang](https://github.com/AdamDang) [#4621](https://github.com/kubernetes/kops/pull/4621)
* Typo "offical"->"official" [@AdamDang](https://github.com/AdamDang) [#4637](https://github.com/kubernetes/kops/pull/4637)
* Typo "official"->"official" [@AdamDang](https://github.com/AdamDang) [#4637](https://github.com/kubernetes/kops/pull/4637)
* Typo delete duplicated "our", fix "reacheable"->"reachable" [@AdamDang](https://github.com/AdamDang) [#4636](https://github.com/kubernetes/kops/pull/4636)
* Fixed typo, us-central should be eu-central [@peterkuiper](https://github.com/peterkuiper) [#4631](https://github.com/kubernetes/kops/pull/4631)
* Typo fix "need"->"needs", delete duplicated "." [@AdamDang](https://github.com/AdamDang) [#4626](https://github.com/kubernetes/kops/pull/4626)
@ -346,7 +346,7 @@ None known at this time
* Update instancegroups.go [@AdamDang](https://github.com/AdamDang) [#4681](https://github.com/kubernetes/kops/pull/4681)
* Fix routetable detection [@justinsb](https://github.com/justinsb) [#4661](https://github.com/kubernetes/kops/pull/4661)
* Define KeysetFormat type, embed into keyset [@justinsb](https://github.com/justinsb) [#4650](https://github.com/kubernetes/kops/pull/4650)
* Typo fix "commmand"->"command" [@AdamDang](https://github.com/AdamDang) [#4682](https://github.com/kubernetes/kops/pull/4682)
* Typo fix "command"->"command" [@AdamDang](https://github.com/AdamDang) [#4682](https://github.com/kubernetes/kops/pull/4682)
* fix 'confimap'->'configmap' [@muhongwei](https://github.com/muhongwei) [#4686](https://github.com/kubernetes/kops/pull/4686)
* Correct spelling mistake [@muhongwei](https://github.com/muhongwei) [#4685](https://github.com/kubernetes/kops/pull/4685)
* [Calico] Fix delay setting up ip routes in new nodes [@felipejfc](https://github.com/felipejfc) [#4589](https://github.com/kubernetes/kops/pull/4589)
@ -448,7 +448,7 @@ None known at this time
* implement router task for OpenStack platform [@zengchen1024](https://github.com/zengchen1024) [#4868](https://github.com/kubernetes/kops/pull/4868)
* add proxy mode flag to kube-proxy [@sergeylanzman](https://github.com/sergeylanzman) [#4863](https://github.com/kubernetes/kops/pull/4863)
* Release 1.9.0-beta.1 [@justinsb](https://github.com/justinsb) [#4871](https://github.com/kubernetes/kops/pull/4871)
* spell depedencies --> dependencies [@sunlintong](https://github.com/sunlintong) [#4861](https://github.com/kubernetes/kops/pull/4861)
* spell dependencies --> dependencies [@sunlintong](https://github.com/sunlintong) [#4861](https://github.com/kubernetes/kops/pull/4861)
* Implement vfs with AlibabaCloud OSS [@ihac](https://github.com/ihac),[@xh4n3](https://github.com/xh4n3) [#4719](https://github.com/kubernetes/kops/pull/4719)
* Adding Mike and myself as reviewers [@robinpercy](https://github.com/robinpercy) [#4874](https://github.com/kubernetes/kops/pull/4874)
* Fix some info errors [@AdamDang](https://github.com/AdamDang) [#4876](https://github.com/kubernetes/kops/pull/4876)
@ -484,7 +484,7 @@ None known at this time
* digitalocean: use pagination for all list requests [@andrewsykim](https://github.com/andrewsykim) [#4923](https://github.com/kubernetes/kops/pull/4923)
* Fix spelling [@inthecloud247](https://github.com/inthecloud247) [#4939](https://github.com/kubernetes/kops/pull/4939)
* Fix grammar mistake [@mycapatin](https://github.com/mycapatin) [#4936](https://github.com/kubernetes/kops/pull/4936)
* Update the reccomended Ubuntu Image [@ofersadgat](https://github.com/ofersadgat) [#4934](https://github.com/kubernetes/kops/pull/4934)
* Update the recommended Ubuntu Image [@ofersadgat](https://github.com/ofersadgat) [#4934](https://github.com/kubernetes/kops/pull/4934)
* Typo fix dont'->don't [@AdamDang](https://github.com/AdamDang) [#4929](https://github.com/kubernetes/kops/pull/4929)
* Update rules go and use more recent debian snapshot [@mikesplain](https://github.com/mikesplain) [#4948](https://github.com/kubernetes/kops/pull/4948)
* fix typo [@mycapatin](https://github.com/mycapatin) [#4943](https://github.com/kubernetes/kops/pull/4943)

2
nodeup/pkg/model/context.go
View File

@ -224,7 +224,7 @@ func (c *NodeupModelContext) UseEtcdTLS() bool {
// UseTLSAuth checks the peer-auth is set in both cluster
// @NOTE: in retrospect i think we should have consolidated the common config in the wrapper struct; it
// feels wierd we set things like version, tls etc per cluster since they both have to be the same.
// feels weird we set things like version, tls etc per cluster since they both have to be the same.
func (c *NodeupModelContext) UseTLSAuth() bool {
if !c.UseEtcdTLS() {
return false

2
nodeup/pkg/model/protokube.go
View File

@ -271,7 +271,7 @@ func (t *ProtokubeBuilder) ProtokubeFlags(k8sVersion semver.Version) (*Protokube
}
}
// TODO this is dupicate code with etcd model
// TODO this is duplicate code with etcd model
image := fmt.Sprintf("k8s.gcr.io/etcd:%s", imageVersion)
// override image if set as API value
if etcdContainerImage != "" {

2
pkg/apis/kops/v1alpha1/cluster.go
View File

@ -323,7 +323,7 @@ type EtcdClusterSpec struct {
Name string `json:"name,omitempty"`
// Members stores the configurations for each member of the cluster (including the data volume)
Members []*EtcdMemberSpec `json:"etcdMembers,omitempty"`
// EnableTLSAuth indicats client and peer TLS auth should be enforced
// EnableTLSAuth indicates client and peer TLS auth should be enforced
EnableTLSAuth bool `json:"enableTLSAuth,omitempty"`
// EnableEtcdTLS indicates the etcd service should use TLS between peers and clients
EnableEtcdTLS bool `json:"enableEtcdTLS,omitempty"`

2
pkg/model/components/apiserver.go
View File

@ -54,7 +54,7 @@ func (b *KubeAPIServerOptionsBuilder) BuildOptions(o interface{}) error {
// @question: should the question every be able to set this?
if c.StorageBackend == nil {
// @note: we can use the first version as we enforce both running the same versions.
// albeit feels a little wierd to do this
// albeit feels a little weird to do this
sem, err := semver.Parse(strings.TrimPrefix(clusterSpec.EtcdClusters[0].Version, "v"))
if err != nil {
return err

2
pkg/openapi/openapi_generated.go
View File

@ -25960,7 +25960,7 @@ func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenA
},
"enableTLSAuth": {
SchemaProps: spec.SchemaProps{
Description: "EnableTLSAuth indicats client and peer TLS auth should be enforced",
Description: "EnableTLSAuth indicates client and peer TLS auth should be enforced",
Type: []string{"boolean"},
Format: "",
},

2
protokube/README.md
View File

@ -47,7 +47,7 @@ mechanism available to us right now is the flags mechanism, so protokube will bu
* Volume discovery, mounting & spawning manifests could be done by kubelet. It might even be possible to do so
today by simply creating a manifest that includes a volume mount, although
kubelet would likely consider a volume that cannot be mounted as a failure state, wheras this is not unexpected
kubelet would likely consider a volume that cannot be mounted as a failure state, whereas this is not unexpected
in available clusters where you might have multiple masters ready to mount the same etcd volume.
* DNS configuration should be done by kubelet.

2
upup/pkg/fi/nodeup/README.md
View File

@ -34,7 +34,7 @@ Owner & group will be root:root
Two special extensions are recognized:
* .asset will be sourced from assets. Assets are binaries that are made available to the installer, e.g. from a .tar.gz distributino
* .asset will be sourced from assets. Assets are binaries that are made available to the installer, e.g. from a .tar.gz distributions
* .template is a go template
packages