From 208199ba85b742d1470c6b7b0deca0dda5bfc559 Mon Sep 17 00:00:00 2001 From: Bharath Vedartham Date: Sun, 15 Nov 2020 11:07:45 +0530 Subject: [PATCH] instancegroups: Clear out the TODO comment Now that we are able to associate pod validation failures with the instance groups. We can remove the TODO comment --- pkg/instancegroups/instancegroups.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/instancegroups/instancegroups.go b/pkg/instancegroups/instancegroups.go index 1a3a8518a8..8c5d5c2ab2 100644 --- a/pkg/instancegroups/instancegroups.go +++ b/pkg/instancegroups/instancegroups.go @@ -491,9 +491,8 @@ func (c *RollingUpdateCluster) validateClusterWithTimeout(validateCount int, gro func hasFailureRelevantToGroup(failures []*validation.ValidationError, group *cloudinstances.CloudInstanceGroup) bool { // Ignore non critical validation errors in other instance groups like below target size errors for _, failure := range failures { - // Determining InstanceGroups for certain resources like Pods, ComponentStatus is not straightforward. - // Till we are able to determine the InstanceGroups for these resources without ambiguity, the - // InstanceGroup field of the ValidationErrors for these resources will be nil + // Certain failures like a system-critical-pod failure and dns server related failures + // set their InstanceGroup to nil, since we cannot associate the failure to any one group if failure.InstanceGroup == nil { return true }