diff --git a/pkg/apis/kops/dockerconfig.go b/pkg/apis/kops/dockerconfig.go index e10f30dfa2..9da3e86818 100644 --- a/pkg/apis/kops/dockerconfig.go +++ b/pkg/apis/kops/dockerconfig.go @@ -21,6 +21,7 @@ type DockerConfig struct { LogLevel *string `json:"logLevel,omitempty" flag:"log-level"` IPTables *bool `json:"ipTables,omitempty" flag:"iptables"` IPMasq *bool `json:"ipMasq,omitempty" flag:"ip-masq"` + LogOpt *string `json:"logOpt,omitempty" flag:"log-opt"` // Storage maps to the docker storage flag // But nodeup will also process a comma-separate list, selecting the first supported option diff --git a/pkg/apis/kops/v1alpha1/dockerconfig.go b/pkg/apis/kops/v1alpha1/dockerconfig.go index 218c166a69..1701df7022 100644 --- a/pkg/apis/kops/v1alpha1/dockerconfig.go +++ b/pkg/apis/kops/v1alpha1/dockerconfig.go @@ -21,6 +21,7 @@ type DockerConfig struct { LogLevel *string `json:"logLevel,omitempty" flag:"log-level"` IPTables *bool `json:"ipTables,omitempty" flag:"iptables"` IPMasq *bool `json:"ipMasq,omitempty" flag:"ip-masq"` + LogOpt *string `json:"logOpt,omitempty" flag:"log-opt"` // Storage maps to the docker storage flag // But nodeup will also process a comma-separate list, selecting the first supported option diff --git a/pkg/apis/kops/v1alpha1/zz_generated.conversion.go b/pkg/apis/kops/v1alpha1/zz_generated.conversion.go index fe8ec74faa..9c48a9e451 100644 --- a/pkg/apis/kops/v1alpha1/zz_generated.conversion.go +++ b/pkg/apis/kops/v1alpha1/zz_generated.conversion.go @@ -659,6 +659,7 @@ func autoConvert_v1alpha1_DockerConfig_To_kops_DockerConfig(in *DockerConfig, ou out.LogLevel = in.LogLevel out.IPTables = in.IPTables out.IPMasq = in.IPMasq + out.LogOpt = in.LogOpt out.Storage = in.Storage out.InsecureRegistry = in.InsecureRegistry out.MTU = in.MTU @@ -676,6 +677,7 @@ func autoConvert_kops_DockerConfig_To_v1alpha1_DockerConfig(in *kops.DockerConfi out.LogLevel = in.LogLevel out.IPTables = in.IPTables out.IPMasq = in.IPMasq + out.LogOpt = in.LogOpt out.Storage = in.Storage out.InsecureRegistry = in.InsecureRegistry out.MTU = in.MTU diff --git a/pkg/apis/kops/v1alpha2/dockerconfig.go b/pkg/apis/kops/v1alpha2/dockerconfig.go index e51e8a25db..89d7265c25 100644 --- a/pkg/apis/kops/v1alpha2/dockerconfig.go +++ b/pkg/apis/kops/v1alpha2/dockerconfig.go @@ -21,6 +21,7 @@ type DockerConfig struct { LogLevel *string `json:"logLevel,omitempty" flag:"log-level"` IPTables *bool `json:"ipTables,omitempty" flag:"iptables"` IPMasq *bool `json:"ipMasq,omitempty" flag:"ip-masq"` + LogOpt *string `json:"logOpt,omitempty" flag:"log-opt"` // Storage maps to the docker storage flag // But nodeup will also process a comma-separate list, selecting the first supported option diff --git a/pkg/apis/kops/v1alpha2/zz_generated.conversion.go b/pkg/apis/kops/v1alpha2/zz_generated.conversion.go index 0d73ddc0ca..0f9b4dad25 100644 --- a/pkg/apis/kops/v1alpha2/zz_generated.conversion.go +++ b/pkg/apis/kops/v1alpha2/zz_generated.conversion.go @@ -741,6 +741,7 @@ func autoConvert_v1alpha2_DockerConfig_To_kops_DockerConfig(in *DockerConfig, ou out.LogLevel = in.LogLevel out.IPTables = in.IPTables out.IPMasq = in.IPMasq + out.LogOpt = in.LogOpt out.Storage = in.Storage out.InsecureRegistry = in.InsecureRegistry out.MTU = in.MTU @@ -758,6 +759,7 @@ func autoConvert_kops_DockerConfig_To_v1alpha2_DockerConfig(in *kops.DockerConfi out.LogLevel = in.LogLevel out.IPTables = in.IPTables out.IPMasq = in.IPMasq + out.LogOpt = in.LogOpt out.Storage = in.Storage out.InsecureRegistry = in.InsecureRegistry out.MTU = in.MTU diff --git a/upup/models/config/components/docker/docker.options b/upup/models/config/components/docker/docker.options index 5370e4c2c6..8f5dbe8b19 100644 --- a/upup/models/config/components/docker/docker.options +++ b/upup/models/config/components/docker/docker.options @@ -5,3 +5,4 @@ Docker: IPMasq: false # Note the alternative syntax... with a comma we will try each of the filesystems in turn Storage: overlay,aufs + LogOpt: "max-size=10m" diff --git a/upup/models/nodeup/logrotate/files/etc/logrotate.d/docker-containers b/upup/models/nodeup/logrotate/files/etc/logrotate.d/docker-containers deleted file mode 100644 index c8f221ffcf..0000000000 --- a/upup/models/nodeup/logrotate/files/etc/logrotate.d/docker-containers +++ /dev/null @@ -1,10 +0,0 @@ -/var/lib/docker/containers/*/*-json.log { - rotate 5 - copytruncate - missingok - notifempty - compress - maxsize 10M - daily - create 0644 root root -} \ No newline at end of file diff --git a/upup/pkg/fi/cloudup/populatecluster_test.go b/upup/pkg/fi/cloudup/populatecluster_test.go index 3dfff2a1e2..c2fb005b4e 100644 --- a/upup/pkg/fi/cloudup/populatecluster_test.go +++ b/upup/pkg/fi/cloudup/populatecluster_test.go @@ -98,6 +98,7 @@ func TestPopulateCluster_Docker_Spec(t *testing.T) { c.Spec.Docker = &api.DockerConfig{ MTU: fi.Int32(5678), InsecureRegistry: fi.String("myregistry.com:1234"), + LogOpt: fi.String("env=FOO"), } err := PerformAssignments(c) @@ -119,6 +120,10 @@ func TestPopulateCluster_Docker_Spec(t *testing.T) { if fi.StringValue(full.Spec.Docker.InsecureRegistry) != "myregistry.com:1234" { t.Fatalf("Unexpected Docker InsecureRegistry: %v", full.Spec.Docker.InsecureRegistry) } + + if fi.StringValue(full.Spec.Docker.LogOpt) != "env=FOO" { + t.Fatalf("Unexpected Docker LogOpt: %v", full.Spec.Docker.LogOpt) + } } func TestPopulateCluster_StorageDefault(t *testing.T) {