remove the unnecessary newline and unused vars

This commit is contained in:
tanjunchen 2019-10-08 22:43:10 +08:00
parent 2afa3490f0
commit 279c429abd
8 changed files with 0 additions and 12 deletions

View File

@ -66,7 +66,6 @@ func (m *AddonMenu) MergeAddons(o *AddonMenu) {
}
func (a *Addon) ChannelVersion() *ChannelVersion {
return &ChannelVersion{
Channel: &a.ChannelName,
Version: a.Spec.Version,
@ -110,7 +109,6 @@ func (a *Addon) GetRequiredUpdates(k8sClient kubernetes.Interface) (*AddonUpdate
}
func (a *Addon) GetManifestFullUrl() (*url.URL, error) {
if a.Spec.Manifest == nil || *a.Spec.Manifest == "" {
return nil, field.Required(field.NewPath("Spec", "Manifest"), "")
}

View File

@ -48,8 +48,6 @@ func (r record) Type() rrstype.RrsType {
return rrstype.RrsType(r.type_)
}
const testDNSZone string = "foo.com"
var testData = []struct {
inputs [2]record
expectedOutput bool

View File

@ -38,7 +38,6 @@ func Test_ParseKubernetesVersion(t *testing.T) {
t.Errorf("version mismatch: %q -> %q but expected %q", version, actual, expected)
}
}
}
func Test_IsKubernetesGTEWithPatch(t *testing.T) {

View File

@ -47,8 +47,6 @@ import (
"k8s.io/kops/util/pkg/exec"
)
const metaFilename = "_etcd_backup.meta"
// EtcdManagerBuilder builds the manifest for the etcd-manager
type EtcdManagerBuilder struct {
*model.KopsModelContext

View File

@ -60,7 +60,6 @@ func (b *ExternalAccessModelBuilder) Build(c *fi.ModelBuilderContext) error {
klog.V(2).Infof("bastion is in use; won't configure SSH access to master / node instances")
} else {
for _, sshAccess := range b.Cluster.Spec.SSHAccess {
for _, masterGroup := range masterGroups {
suffix := masterGroup.Suffix
t := &awstasks.SecurityGroupRule{

View File

@ -35,8 +35,6 @@ type MeshGossiper struct {
peer *peer
version uint64
lastSnapshot *gossip.GossipStateSnapshot
}
func NewMeshGossiper(listen string, channelName string, nodeName string, password []byte, seeds gossip.SeedProvider) (*MeshGossiper, error) {

View File

@ -114,7 +114,6 @@ func (d *DOVolumes) AttachVolume(volume *Volume) error {
time.Sleep(10 * time.Second)
}
}
func (d *DOVolumes) FindVolumes() ([]*Volume, error) {

View File

@ -325,7 +325,6 @@ func (v *AutoscalingGroup) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *Autos
if e.InstanceProtection != nil {
request.NewInstancesProtectedFromScaleIn = e.InstanceProtection
}
} else {
// @logic: else we have found a autoscaling group and we need to evaluate the difference
request := &autoscaling.UpdateAutoScalingGroupInput{