From 2e920d75c119f656e2e543673464dd28190a9840 Mon Sep 17 00:00:00 2001 From: John Gardiner Myers Date: Sun, 15 Mar 2020 17:21:06 -0700 Subject: [PATCH] Fix command descriptions to match new cluster validation behavior --- cmd/kops/rollingupdatecluster.go | 2 +- cmd/kops/validate.go | 2 +- docs/cli/kops_rolling-update.md | 2 +- docs/cli/kops_rolling-update_cluster.md | 2 +- docs/cli/kops_validate.md | 2 +- docs/cli/kops_validate_cluster.md | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cmd/kops/rollingupdatecluster.go b/cmd/kops/rollingupdatecluster.go index 8d12f22f60..32907bfa1f 100644 --- a/cmd/kops/rollingupdatecluster.go +++ b/cmd/kops/rollingupdatecluster.go @@ -52,7 +52,7 @@ var ( If rolling-update does not report that the cluster needs to be rolled, you can force the cluster to be rolled with the force flag. Rolling update drains and validates the cluster by default. A cluster is - deemed validated when all required nodes are running and all pods in the kube-system namespace are operational. + deemed validated when all required nodes are running and all pods with a critical priority are operational. When a node is deleted, rolling-update sleeps the interval for the node type, and then tries for the same period of time for the cluster to be validated. For instance, setting --master-interval=3m causes rolling-update to wait for 3 minutes after a master is rolled, and another 3 minutes for the cluster to stabilize and pass diff --git a/cmd/kops/validate.go b/cmd/kops/validate.go index a911d6b31c..907b3e35bd 100644 --- a/cmd/kops/validate.go +++ b/cmd/kops/validate.go @@ -32,7 +32,7 @@ var ( 1. All k8s masters are running and have "Ready" status. 2. All k8s nodes are running and have "Ready" status. 3. Component status returns healthy for all components. - 4. All pods in the kube-system namespace are running and healthy. + 4. All pods with a critical priority are running and healthy. `)) validateExample = templates.Examples(i18n.T(` diff --git a/docs/cli/kops_rolling-update.md b/docs/cli/kops_rolling-update.md index 2db99e2cfd..efae13a7e4 100644 --- a/docs/cli/kops_rolling-update.md +++ b/docs/cli/kops_rolling-update.md @@ -15,7 +15,7 @@ To perform a rolling update, you need to update the cloud resources first with t If rolling-update does not report that the cluster needs to be rolled, you can force the cluster to be rolled with the force flag. Rolling update drains and validates the cluster by default. A cluster is -deemed validated when all required nodes are running and all pods in the kube-system namespace are operational. +deemed validated when all required nodes are running and all pods with a critical priority are operational. When a node is deleted, rolling-update sleeps the interval for the node type, and then tries for the same period of time for the cluster to be validated. For instance, setting --master-interval=3m causes rolling-update to wait for 3 minutes after a master is rolled, and another 3 minutes for the cluster to stabilize and pass diff --git a/docs/cli/kops_rolling-update_cluster.md b/docs/cli/kops_rolling-update_cluster.md index 7e939c0745..493072e3e4 100644 --- a/docs/cli/kops_rolling-update_cluster.md +++ b/docs/cli/kops_rolling-update_cluster.md @@ -15,7 +15,7 @@ To perform a rolling update, you need to update the cloud resources first with t If rolling-update does not report that the cluster needs to be rolled, you can force the cluster to be rolled with the force flag. Rolling update drains and validates the cluster by default. A cluster is -deemed validated when all required nodes are running and all pods in the kube-system namespace are operational. +deemed validated when all required nodes are running and all pods with a critical priority are operational. When a node is deleted, rolling-update sleeps the interval for the node type, and then tries for the same period of time for the cluster to be validated. For instance, setting --master-interval=3m causes rolling-update to wait for 3 minutes after a master is rolled, and another 3 minutes for the cluster to stabilize and pass diff --git a/docs/cli/kops_validate.md b/docs/cli/kops_validate.md index 7077dbf701..1168b3d2ad 100644 --- a/docs/cli/kops_validate.md +++ b/docs/cli/kops_validate.md @@ -12,7 +12,7 @@ This commands validates the following components: 1. All k8s masters are running and have "Ready" status. 2. All k8s nodes are running and have "Ready" status. 3. Component status returns healthy for all components. - 4. All pods in the kube-system namespace are running and healthy. + 4. All pods with a critical priority are running and healthy. ### Examples diff --git a/docs/cli/kops_validate_cluster.md b/docs/cli/kops_validate_cluster.md index 3a779c6976..3256c85b91 100644 --- a/docs/cli/kops_validate_cluster.md +++ b/docs/cli/kops_validate_cluster.md @@ -12,7 +12,7 @@ This commands validates the following components: 1. All k8s masters are running and have "Ready" status. 2. All k8s nodes are running and have "Ready" status. 3. Component status returns healthy for all components. - 4. All pods in the kube-system namespace are running and healthy. + 4. All pods with a critical priority are running and healthy. ``` kops validate cluster [flags]