From 32b3ae8adebf1f43f1d574edeccce4322f4fd1a4 Mon Sep 17 00:00:00 2001 From: Nicolas Sterchele Date: Tue, 2 Aug 2022 14:41:53 +0200 Subject: [PATCH] aws-ebs-csi-driver: remove preStop hook The hook can cause issue on execution, like ``` Exec lifecycle hook ([/bin/sh -c rm -rf /registration/ebs.csi.aws.com-reg.sock /csi/csi.sock]) for Container "node-driver-registrar" in Pod "ebs-csi-node-96jbk_ebs-csi(a82c6d41-bd2b-42dd-b092-e3acd4c43b62)" failed - error: command '/bin/sh -c rm -rf /registration/ebs.csi.aws.com-reg.sock /csi/csi.sock' exited with 126: , message: "OCI runtime exec failed: exec failed: container_linux.go:370: starting container process caused: exec: \"/bin/sh\": stat /bin/sh: no such file or directory: unknown\r\n" ``` Moreover, it has been deleted from upstream driver, see this patch https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/778/commits/6e59160eeaeb7296d196a6510029e718c0752e63 Signed-off-by: Nicolas Sterchele --- .../aws-ebs-csi-driver.addons.k8s.io/k8s-1.17.yaml.template | 4 ---- 1 file changed, 4 deletions(-) diff --git a/upup/models/cloudup/resources/addons/aws-ebs-csi-driver.addons.k8s.io/k8s-1.17.yaml.template b/upup/models/cloudup/resources/addons/aws-ebs-csi-driver.addons.k8s.io/k8s-1.17.yaml.template index 36c4a680af..f0c0992e87 100644 --- a/upup/models/cloudup/resources/addons/aws-ebs-csi-driver.addons.k8s.io/k8s-1.17.yaml.template +++ b/upup/models/cloudup/resources/addons/aws-ebs-csi-driver.addons.k8s.io/k8s-1.17.yaml.template @@ -337,10 +337,6 @@ spec: - --csi-address=$(ADDRESS) - --kubelet-registration-path=$(DRIVER_REG_SOCK_PATH) - --v=5 - lifecycle: - preStop: - exec: - command: ["/bin/sh", "-c", "rm -rf /registration/ebs.csi.aws.com-reg.sock /csi/csi.sock"] env: - name: ADDRESS value: /csi/csi.sock