updating found govet issues and adding test directory

This commit is contained in:
chrislovecnm 2017-06-23 16:42:33 -06:00
parent 8585f00717
commit 38aae71bee
3 changed files with 5 additions and 4 deletions

View File

@ -397,7 +397,8 @@ govet:
k8s.io/kops/util/... \
k8s.io/kops/upup/... \
k8s.io/kops/protokube/... \
k8s.io/kops/dns-controller/...
k8s.io/kops/dns-controller/... \
k8s.io/kops/tests/...
# --------------------------------------------------

View File

@ -87,7 +87,7 @@ func RunGetInstanceGroups(options *GetInstanceGroupsOptions, args []string) erro
cluster, err := clientset.GetCluster(clusterName)
if err != nil {
return fmt.Errorf("error fetching cluster %q: %v", cluster, err)
return fmt.Errorf("error fetching cluster %q: %v", clusterName, err)
}
list, err := clientset.InstanceGroupsFor(cluster).List(metav1.ListOptions{})

View File

@ -105,7 +105,7 @@ func TestKopsUpgrades(t *testing.T) {
required, err := versionInfo.IsUpgradeRequired(kopsVersion)
if err != nil {
t.Errorf("unexpected error from IsUpgradeRequired(%q)", g.KopsVersion, err)
t.Errorf("unexpected error from IsUpgradeRequired(%q): %v", g.KopsVersion, err)
continue
}
if required != g.ExpectedRequired {
@ -199,7 +199,7 @@ func TestKubernetesUpgrades(t *testing.T) {
required, err := versionInfo.IsUpgradeRequired(kubernetesVersion)
if err != nil {
t.Errorf("unexpected error from IsUpgradeRequired(%q)", g.KubernetesVersion, err)
t.Errorf("unexpected error from IsUpgradeRequired(%q): %v", g.KubernetesVersion, err)
continue
}
if required != g.ExpectedRequired {