kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1787 from justinsb/really_retry_on_404 

Actually retry on HTTP 404s
This commit is contained in:
Justin Santa Barbara 2017-02-06 20:14:06 -05:00 committed by GitHub
parent a909f38b9c 1e5dab5a6c
commit 38b4cbff54
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
util/pkg/vfs/context.go
View File

@ -132,7 +132,7 @@ func (c *VFSContext) readHttpLocation(httpURL string, httpHeaders map[string]str
} }
if response.StatusCode == 404 { if response.StatusCode == 404 {
// We retry on 404s in case of eventual consistency // We retry on 404s in case of eventual consistency
return true, os.ErrNotExist return false, os.ErrNotExist
} }
if response.StatusCode >= 500 && response.StatusCode <= 599 { if response.StatusCode >= 500 && response.StatusCode <= 599 {
// Retry on 5XX errors // Retry on 5XX errors
@ -173,17 +173,18 @@ func RetryWithBackoff(backoff wait.Backoff, condition func() (bool, error)) (boo
i++ i++
ok, err := condition() done, err := condition()
if ok { if done {
return ok, err return done, err
} }
noMoreRetries := (i + 1) >= backoff.Steps noMoreRetries := i >= backoff.Steps
if !noMoreRetries && err != nil { if !noMoreRetries && err != nil {
glog.V(2).Infof("retrying after error %v", err) glog.V(2).Infof("retrying after error %v", err)
} }
if noMoreRetries { if noMoreRetries {
return ok, err glog.V(2).Infof("hit maximum retries %d with error %v", i, err)
return done, err
} }
} }
} }