mirror of https://github.com/kubernetes/kops.git
Remove unnecessary code
This commit is contained in:
parent
0febb373a7
commit
3a346cdc37
|
|
@ -552,10 +552,6 @@ const (
|
||||||
EtcdProviderTypeManager EtcdProviderType = "Manager"
|
EtcdProviderTypeManager EtcdProviderType = "Manager"
|
||||||
)
|
)
|
||||||
|
|
||||||
var SupportedEtcdProviderTypes = []string{
|
|
||||||
string(EtcdProviderTypeManager),
|
|
||||||
}
|
|
||||||
|
|
||||||
// EtcdClusterSpec is the etcd cluster specification
|
// EtcdClusterSpec is the etcd cluster specification
|
||||||
type EtcdClusterSpec struct {
|
type EtcdClusterSpec struct {
|
||||||
// Name is the name of the etcd cluster (main, events etc)
|
// Name is the name of the etcd cluster (main, events etc)
|
||||||
|
|
|
||||||
|
|
@ -1004,7 +1004,7 @@ func validateEtcdClusterSpec(spec kops.EtcdClusterSpec, c *kops.Cluster, fieldPa
|
||||||
}
|
}
|
||||||
if spec.Provider != "" {
|
if spec.Provider != "" {
|
||||||
value := string(spec.Provider)
|
value := string(spec.Provider)
|
||||||
allErrs = append(allErrs, IsValidValue(fieldPath.Child("provider"), &value, kops.SupportedEtcdProviderTypes)...)
|
allErrs = append(allErrs, IsValidValue(fieldPath.Child("provider"), &value, []string{string(kops.EtcdProviderTypeManager)})...)
|
||||||
}
|
}
|
||||||
if len(spec.Members) == 0 {
|
if len(spec.Members) == 0 {
|
||||||
allErrs = append(allErrs, field.Required(fieldPath.Child("etcdMembers"), "No members defined in etcd cluster"))
|
allErrs = append(allErrs, field.Required(fieldPath.Child("etcdMembers"), "No members defined in etcd cluster"))
|
||||||
|
|
|
||||||
|
|
@ -17,9 +17,6 @@ limitations under the License.
|
||||||
package components
|
package components
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"fmt"
|
|
||||||
"strings"
|
|
||||||
|
|
||||||
"k8s.io/kops/pkg/apis/kops"
|
"k8s.io/kops/pkg/apis/kops"
|
||||||
"k8s.io/kops/upup/pkg/fi/loader"
|
"k8s.io/kops/upup/pkg/fi/loader"
|
||||||
)
|
)
|
||||||
|
|
@ -43,10 +40,6 @@ func (b *EtcdOptionsBuilder) BuildOptions(o interface{}) error {
|
||||||
|
|
||||||
for i := range spec.EtcdClusters {
|
for i := range spec.EtcdClusters {
|
||||||
c := &spec.EtcdClusters[i]
|
c := &spec.EtcdClusters[i]
|
||||||
if c.Provider == "" {
|
|
||||||
c.Provider = kops.EtcdProviderTypeManager
|
|
||||||
}
|
|
||||||
|
|
||||||
// Ensure the version is set
|
// Ensure the version is set
|
||||||
if c.Version == "" {
|
if c.Version == "" {
|
||||||
// We run the k8s-recommended versions of etcd
|
// We run the k8s-recommended versions of etcd
|
||||||
|
|
@ -58,12 +51,6 @@ func (b *EtcdOptionsBuilder) BuildOptions(o interface{}) error {
|
||||||
c.Version = DefaultEtcd3Version_1_17
|
c.Version = DefaultEtcd3Version_1_17
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// We make sure that etcd v3 is used
|
|
||||||
version := strings.TrimPrefix(c.Version, "v")
|
|
||||||
if !strings.HasPrefix(version, "3.") {
|
|
||||||
return fmt.Errorf("unexpected etcd version %q", c.Version)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue