kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #14215 from justinsb/dont_swallow_misc_aws_errors 

AWS IAM Role listing: don't ignore "other" errors
This commit is contained in:
Kubernetes Prow Robot 2022-09-01 12:15:19 -07:00 committed by GitHub
parent bcbd1fa1c5 90a484f049
commit 3b5dccdf5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/resources/aws/aws.go
View File

@ -2012,11 +2012,10 @@ func ListIAMRoles(cloud fi.Cloud, clusterName string) ([]*resources.Resource, er
klog.Warningf("could not find instance profile %q. Resource may already have been deleted: %v", name, awserror) klog.Warningf("could not find instance profile %q. Resource may already have been deleted: %v", name, awserror)
continue continue
} }
} else { }
getRoleErr = fmt.Errorf("calling IAM GetRole on %s: %w", name, err) getRoleErr = fmt.Errorf("calling IAM GetRole on %s: %w", name, err)
return false return false
} }
}
for _, tag := range roleOutput.Role.Tags { for _, tag := range roleOutput.Role.Tags {
if fi.StringValue(tag.Key) == ownershipTag && fi.StringValue(tag.Value) == "owned" { if fi.StringValue(tag.Key) == ownershipTag && fi.StringValue(tag.Value) == "owned" {
resourceTracker := &resources.Resource{ resourceTracker := &resources.Resource{