kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review 

Co-Authored-By: John Gardiner Myers <jgmyers@proofpoint.com>
This commit is contained in:
Ole Markus With 2020-04-05 21:28:14 +02:00 committed by Ole Markus With
parent cb8f3e5594
commit 4000988b01
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
k8s/crds/kops.k8s.io_clusters.yaml
View File

@ -2071,7 +2071,7 @@ spec:
type: string
topologyManagerPolicy:
description: TopologyManagerPolicy determines the allocation policy
for the topology manager
for the topology manager.
type: string
volumePluginDirectory:
description: The full path of the directory in which to search for
@ -2433,7 +2433,7 @@ spec:
type: string
topologyManagerPolicy:
description: TopologyManagerPolicy determines the allocation policy
for the topology manager
for the topology manager.
type: string
volumePluginDirectory:
description: The full path of the directory in which to search for

2
k8s/crds/kops.k8s.io_instancegroups.yaml
View File

@ -553,7 +553,7 @@ spec:
type: string
topologyManagerPolicy:
description: TopologyManagerPolicy determines the allocation policy
for the topology manager
for the topology manager.
type: string
volumePluginDirectory:
description: The full path of the directory in which to search for

2
pkg/apis/kops/componentconfig.go
View File

@ -196,7 +196,7 @@ type KubeletConfigSpec struct {
RegistryPullQPS *int32 `json:"registryPullQPS,omitempty" flag:"registry-qps"`
//RegistryBurst Maximum size of a bursty pulls, temporarily allows pulls to burst to this number, while still not exceeding registry-qps. Only used if --registry-qps > 0 (default 10)
RegistryBurst *int32 `json:"registryBurst,omitempty" flag:"registry-burst"`
//TopologyManagerPolicy determines the allocation policy for the topology manager
//TopologyManagerPolicy determines the allocation policy for the topology manager.
TopologyManagerPolicy string `json:"topologyManagerPolicy,omitempty" flag:"topology-manager-policy"`
// rotateCertificates enables client certificate rotation.

2
pkg/apis/kops/v1alpha2/componentconfig.go
View File

@ -196,7 +196,7 @@ type KubeletConfigSpec struct {
RegistryPullQPS *int32 `json:"registryPullQPS,omitempty" flag:"registry-qps"`
//RegistryBurst Maximum size of a bursty pulls, temporarily allows pulls to burst to this number, while still not exceeding registry-qps. Only used if --registry-qps > 0 (default 10)
RegistryBurst *int32 `json:"registryBurst,omitempty" flag:"registry-burst"`
//TopologyManagerPolicy determines the allocation policy for the topology manager
//TopologyManagerPolicy determines the allocation policy for the topology manager.
TopologyManagerPolicy string `json:"topologyManagerPolicy,omitempty" flag:"topology-manager-policy"`
// rotateCertificates enables client certificate rotation.

2
pkg/apis/kops/validation/legacy.go
View File

@ -41,7 +41,7 @@ func ValidateCluster(c *kops.Cluster, strict bool) field.ErrorList {
allErrs := field.ErrorList{}
// KubernetesVersion
// This is one case we return error because a large part of the rest of the validation logic depend on a valid kubernetes version.
// This is one case we return the error because a large part of the rest of the validation logic depends on a valid kubernetes version.
if c.Spec.KubernetesVersion == "" {
allErrs = append(allErrs, field.Required(fieldSpec.Child("kubernetesVersion"), ""))