kubernetes
/
kops
mirror of https://github.com/kubernetes/kops.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Github download url for nodeup 

Currently this generates:
```
NODEUP_URL=https://artifacts.k8s.io/binaries/kops/1.15.1/linux/amd64/nodeup,https://github.com/kubernetes/kops/releases/download/1.15.1/linux-amd64-nodeup,https://kubeupv2.s3.amazonaws.com/kops/1.15.1/linux/amd64/nodeup
NODEUP_HASH=de4939eadb6e4d89fcf608b1f632e770bcce521d6dc5c45d76d2c4608ad23db4
```

However for the Github URL a `v` is missing in front of the version tag.

Returns a 404:
```
curl https://github.com/kubernetes/kops/releases/download/1.15.1/linux-amd64-nodeup
```

Downloads the file:
```
curl https://github.com/kubernetes/kops/releases/download/v1.15.1/linux-amd64-nodeup
```
This commit is contained in:
Adrian Philipp 2020-02-04 14:24:48 +01:00 committed by GitHub
parent 6c202ef375
commit 4982a94721
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
upup/pkg/fi/cloudup/urls.go
View File

@ -49,7 +49,7 @@ type mirror struct {
// Note that we download in order
var defaultKopsMirrors = []mirror{
{URL: "https://artifacts.k8s.io/binaries/kops/%s/"},
{URL: "https://github.com/kubernetes/kops/releases/download/%s/", Replace: map[string]string{"/": "-"}},
{URL: "https://github.com/kubernetes/kops/releases/download/v%s/", Replace: map[string]string{"/": "-"}},
// We do need to include defaultKopsMirrorBase - the list replaces the base url
{URL: "https://kubeupv2.s3.amazonaws.com/kops/%s/"},
}