From 5cb63fb788b0a4ea85cd35f140992d91b19c3574 Mon Sep 17 00:00:00 2001 From: Ole Markus With Date: Wed, 26 Aug 2020 13:41:15 +0200 Subject: [PATCH] Fail if we find multiple sgs with same name --- pkg/model/openstackmodel/firewall.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/model/openstackmodel/firewall.go b/pkg/model/openstackmodel/firewall.go index be2d453ee5..c688425505 100644 --- a/pkg/model/openstackmodel/firewall.go +++ b/pkg/model/openstackmodel/firewall.go @@ -497,9 +497,12 @@ func (b *FirewallModelBuilder) getExistingRules(sgMap map[string]*openstacktasks if err != nil { return err } - if len(sgs) != 1 { + if len(sgs) == 0 { continue } + if len(sgs) > 1 { + return fmt.Errorf("Found multiple security groups with the same name: %v", sgName) + } sg := sgs[0] sgt.Name = fi.String(sg.Name) sgIdMap[sg.ID] = sgt