From 5d8ebcd34ff4e4fb8003f0d659cda8d9c410e326 Mon Sep 17 00:00:00 2001 From: Justin Santa Barbara Date: Sun, 13 Nov 2016 22:29:48 -0500 Subject: [PATCH] Fixes per code review --- dns-controller/pkg/watchers/servicecontroller.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dns-controller/pkg/watchers/servicecontroller.go b/dns-controller/pkg/watchers/servicecontroller.go index 449e176a11..4478f798ee 100644 --- a/dns-controller/pkg/watchers/servicecontroller.go +++ b/dns-controller/pkg/watchers/servicecontroller.go @@ -151,14 +151,14 @@ func (c *ServiceController) updateServiceRecords(service *v1.Service) { RecordType: dns.RecordTypeCNAME, Value: ingress.Hostname, }) - glog.V(4).Infof("Found CNAME for service %s/%s: %q", service.Namespace, service.Name, ingress.Hostname) + glog.V(4).Infof("Found CNAME record for service %s/%s: %q", service.Namespace, service.Name, ingress.Hostname) } if ingress.IP != "" { ingresses = append(ingresses, dns.Record{ RecordType: dns.RecordTypeA, Value: ingress.IP, }) - glog.V(4).Infof("Found A for service %s/%s: %q", service.Namespace, service.Name, ingress.IP) + glog.V(4).Infof("Found A record for service %s/%s: %q", service.Namespace, service.Name, ingress.IP) } } } else if service.Spec.Type == v1.ServiceTypeNodePort { @@ -168,6 +168,7 @@ func (c *ServiceController) updateServiceRecords(service *v1.Service) { }) glog.V(4).Infof("Setting internal alias for NodePort service %s/%s", service.Namespace, service.Name) } else { + // TODO: Emit event so that users are informed of this glog.V(2).Infof("Cannot expose service %s/%s of type %q", service.Namespace, service.Name, service.Spec.Type) } @@ -184,7 +185,7 @@ func (c *ServiceController) updateServiceRecords(service *v1.Service) { } } } else { - glog.V(4).Infof("Service %s/%s did not have %s annotation", service.Namespace, service.Name, AnnotationNameDnsExternal) + glog.V(8).Infof("Service %s/%s did not have %s annotation", service.Namespace, service.Name, AnnotationNameDnsExternal) } c.scope.Replace(service.Name, records)